From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook Date: Sun, 30 Aug 2015 20:10:28 +0200 Message-ID: <55E34714.7080608@gmx.at> References: <83mvx8252m.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1440958283 987 80.91.229.3 (30 Aug 2015 18:11:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Aug 2015 18:11:23 +0000 (UTC) Cc: 21380@debbugs.gnu.org To: Pip Cet , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 30 20:11:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZW74R-0006Ub-G5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Aug 2015 20:11:11 +0200 Original-Received: from localhost ([::1]:59848 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZW74R-0007Z5-II for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Aug 2015 14:11:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZW74N-0007Yt-JN for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2015 14:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZW74I-00042T-KX for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2015 14:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZW74I-00042N-Hv for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2015 14:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZW74I-00022Z-38 for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2015 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2015 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21380-submit@debbugs.gnu.org id=B21380.14409582467821 (code B ref 21380); Sun, 30 Aug 2015 18:11:02 +0000 Original-Received: (at 21380) by debbugs.gnu.org; 30 Aug 2015 18:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:43002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZW742-000224-0k for submit@debbugs.gnu.org; Sun, 30 Aug 2015 14:10:46 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:50084) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZW73z-00021v-B9 for 21380@debbugs.gnu.org; Sun, 30 Aug 2015 14:10:44 -0400 Original-Received: from [188.22.232.77] ([188.22.232.77]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0ML72n-1ZVpwk3Iqv-000Oth; Sun, 30 Aug 2015 20:10:39 +0200 In-Reply-To: X-Provags-ID: V03:K0:OxUqQeaVpHW1MB4j75E5gXlJWNNTYlY9Gmz8UCWas13H95lqgiE eQZN0WRVwrqJqkvLOrkgSGNm89KVTVJ6TG2twMaPkomVEfKPJlmHYwKnGIBsa49L6KCKJtz W414vGm48WgLGT84/IOACwgjSwRoNTTevTGVNfTxR2ezzDRTcyQlJOWfdwsE9vArg3O1UBv hbhbxPv49j2PGE3+tTGCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:48WAOO9ZmbQ=:q2qI2LvyrpeTFGXPYcppxD L/5XLXZ1MOXQFuA4avOK4HowYFLynUnyvbzjLKfU6vtZrsmY3/PzDcdUO0Asrze4K6HeqgKrm 7Ru1srRaQ0JO8nxw76IxNfNJtFUSvNHF99y8/h88HemfDNHAMbFcQkIK8W6tTpUGN6d9xKfeG TxmmLaqVMxGoODyykPTuvxfGfbffo33PELD7LkH26156hWORE1DAbhvweIy8C6MYurgLYkzqi X/A6n9rtG4WXHMDKNwlkliqWDPM+WwQp7bRMr5VTPTyu+zh5L1hnMG4bJwL4A3PeO+onAjjlS JG7fExL3Pl+NdjcWQ8iJSjHbCVtW1/biAagoSsj6isFk5rfqysbPzdSu9bPOZ9NezNibhyiO2 t88HBwxCqJVYSmaFL/LNQvyyJl3+LWuJoZ13gnOQUucIAZa4RvexF3X4PHA6k+0I/FHZTJJG/ x9TtLLkdLMA+U8h+GorohwUjQOqabZxSwJ9puQv/JDD3wqCBDshve9z8mQ8f7ONWVvjwPoltq HGjBGKHE6R+cNoAjFZ3o52/Raf/sA0SZ9xbxW3ZcL3+j1x+e3pjvfRc2pQYl+wO/f9PAJcYTv 2A31YC5ov7UOG/XAoXyCrBqgYqvWH6OxLhNGQemB9aYubjuC3BEaT8BpzspOJg++2pDLPwnFI 1a6JvwQWqVqq3Guhc0/wBBL/lBKsmfL09+9YMtV6MFlRH3boqSwaEyhs5CjXomF/nSm0wfOQN a/yll/F0YGpc2qRu/Vib2zXpYHsdiHUvOXT8+w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105987 Archived-At: > I think the problem is the call to do_pending_window_change in > xg_frame_resized in gtkutil.c: the commit message (commit 3477e27021db= ) > says: > > Author: Martin Rudalics > AuthorDate: Sun Jul 27 15:21:30 2014 +0200 > Commit: Martin Rudalics > CommitDate: Sun Jul 27 15:21:30 2014 +0200 > > Complete pixelwise frame/window resizing, add horizontal scrollba= r > support. > [...] > * gtkutil.c (xg_frame_resized): Don't call > do_pending_window_change. > > but the diff is: > > @@ -883,6 +884,8 @@ xg_frame_resized (struct frame *f, int pixelwidth,= int > pixelheight) > change_frame_size (f, width, height, 0, 1, 0, 1); > SET_FRAME_GARBAGED (f); > cancel_mouse_face (f); > + > + do_pending_window_change (0); > } > } Remarkable. I don't remember why I added them. And obviously I have no idea why I wrote the ChangeLog entry in reverse. Just as if I read diff output in the wrong direction. In my understanding the do_pending_window_change call is not needed and usually should be a noop. But I have no idea why this particular call of do_pending_window_change would run =E2=80=98window-configuration-chang= e-hook=E2=80=99 and subsequently cause the havoc you describe. The last change_frame_size should have just happened three lines before. > And my current understanding is this bug would not occur if that call = were > removed. The same issue applies to the change to x_set_window_size, bu= t I'm > not certain about removing either call. Maybe. But the cause of the SEGFAULT must be elsewhere. I have no idea how 4. make_list interrupted by QUIT could happen "while the temporary copy is being created" when timer_check has set Vinhibit_quit to t. martin