From: martin rudalics <rudalics@gmx.at>
To: Pip Cet <pipcet@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 21380@debbugs.gnu.org
Subject: bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook
Date: Sun, 30 Aug 2015 20:10:28 +0200 [thread overview]
Message-ID: <55E34714.7080608@gmx.at> (raw)
In-Reply-To: <CAOqdjBd6EZ-zC0-AOa-XCawFSJkzfZzEWcp8O52qbi2Dxh=r5w@mail.gmail.com>
> I think the problem is the call to do_pending_window_change in
> xg_frame_resized in gtkutil.c: the commit message (commit 3477e27021db)
> says:
>
> Author: Martin Rudalics <rudalics@gmx.at>
> AuthorDate: Sun Jul 27 15:21:30 2014 +0200
> Commit: Martin Rudalics <rudalics@gmx.at>
> CommitDate: Sun Jul 27 15:21:30 2014 +0200
>
> Complete pixelwise frame/window resizing, add horizontal scrollbar
> support.
> [...]
> * gtkutil.c (xg_frame_resized): Don't call
> do_pending_window_change.
>
> but the diff is:
>
> @@ -883,6 +884,8 @@ xg_frame_resized (struct frame *f, int pixelwidth, int
> pixelheight)
> change_frame_size (f, width, height, 0, 1, 0, 1);
> SET_FRAME_GARBAGED (f);
> cancel_mouse_face (f);
> +
> + do_pending_window_change (0);
> }
> }
Remarkable. I don't remember why I added them. And obviously I have no
idea why I wrote the ChangeLog entry in reverse. Just as if I read diff
output in the wrong direction.
In my understanding the do_pending_window_change call is not needed and
usually should be a noop. But I have no idea why this particular call
of do_pending_window_change would run ‘window-configuration-change-hook’
and subsequently cause the havoc you describe. The last
change_frame_size should have just happened three lines before.
> And my current understanding is this bug would not occur if that call were
> removed. The same issue applies to the change to x_set_window_size, but I'm
> not certain about removing either call.
Maybe. But the cause of the SEGFAULT must be elsewhere. I have no
idea how
4. make_list interrupted by QUIT
could happen "while the temporary copy is being created" when
timer_check has set Vinhibit_quit to t.
martin
next prev parent reply other threads:[~2015-08-30 18:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 12:51 bug#21380: 25.0.50; GTK-induced segfault when scheduling timer from window-configuration-change-hook Pip Cet
2015-08-30 15:01 ` Eli Zaretskii
2015-08-30 15:24 ` Pip Cet
2015-08-30 15:27 ` Pip Cet
2015-08-30 16:24 ` Pip Cet
2015-08-30 18:10 ` martin rudalics [this message]
2015-08-30 18:20 ` Pip Cet
2015-08-30 19:50 ` Eli Zaretskii
2015-08-30 18:59 ` Pip Cet
2015-08-31 9:20 ` martin rudalics
2015-08-30 16:39 ` Eli Zaretskii
2015-08-30 16:42 ` Pip Cet
2015-08-30 19:44 ` Eli Zaretskii
2015-08-30 20:56 ` Pip Cet
2015-08-30 21:13 ` Pip Cet
2015-08-31 14:31 ` Eli Zaretskii
2015-09-01 10:20 ` Pip Cet
2015-09-01 15:03 ` Eli Zaretskii
2015-09-01 15:22 ` Pip Cet
2015-09-01 16:01 ` Eli Zaretskii
2015-09-01 16:02 ` Pip Cet
2015-09-01 16:23 ` Eli Zaretskii
2015-09-02 7:02 ` martin rudalics
2015-09-02 14:32 ` Eli Zaretskii
2015-09-03 15:36 ` Stefan Monnier
2015-09-05 7:38 ` Eli Zaretskii
2015-09-05 15:18 ` Stefan Monnier
2015-09-05 15:27 ` Eli Zaretskii
2015-09-06 22:11 ` Stefan Monnier
2022-04-29 12:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 13:40 ` Eli Zaretskii
2022-04-29 13:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 15:02 ` Pip Cet
2015-09-05 16:59 ` Pip Cet
2015-09-06 22:22 ` Stefan Monnier
2015-09-08 15:55 ` Pip Cet
2015-09-01 15:14 ` Pip Cet
2015-09-01 16:04 ` Eli Zaretskii
2015-09-01 16:56 ` Pip Cet
2015-09-01 17:19 ` Eli Zaretskii
2015-09-01 20:48 ` Pip Cet
2015-09-02 15:08 ` Eli Zaretskii
2015-09-02 16:09 ` Pip Cet
2015-09-02 19:13 ` Eli Zaretskii
2015-09-02 22:08 ` Pip Cet
2020-09-07 17:07 ` Lars Ingebrigtsen
2020-09-07 17:47 ` Pip Cet
2020-09-07 19:09 ` Eli Zaretskii
2020-09-08 9:57 ` Lars Ingebrigtsen
2022-04-29 12:14 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E34714.7080608@gmx.at \
--to=rudalics@gmx.at \
--cc=21380@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.