From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21333: 25.0.50; window-size-change-functions not called after mini-window resize Date: Wed, 26 Aug 2015 09:08:45 +0200 Message-ID: <55DD65FD.1000206@gmx.at> References: <83k2skhhz1.fsf@gnu.org> <55DB5D3E.1000706@gmx.at> <83vbc4fsjd.fsf@gnu.org> <55DC1856.7000501@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1440572975 18437 80.91.229.3 (26 Aug 2015 07:09:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Aug 2015 07:09:35 +0000 (UTC) Cc: 21333@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 26 09:09:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZUUpm-00067X-Uy for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Aug 2015 09:09:23 +0200 Original-Received: from localhost ([::1]:36431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUUpm-0005xR-EP for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Aug 2015 03:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUUpT-0005V4-3T for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2015 03:09:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUUpS-0006i3-9E for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2015 03:09:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUUpS-0006hx-74 for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2015 03:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZUUpR-0002Ym-Kv for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2015 03:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2015 07:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21333-submit@debbugs.gnu.org id=B21333.14405729349826 (code B ref 21333); Wed, 26 Aug 2015 07:09:01 +0000 Original-Received: (at 21333) by debbugs.gnu.org; 26 Aug 2015 07:08:54 +0000 Original-Received: from localhost ([127.0.0.1]:38533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUUpK-0002YQ-Df for submit@debbugs.gnu.org; Wed, 26 Aug 2015 03:08:54 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:64955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZUUpI-0002YH-CV for 21333@debbugs.gnu.org; Wed, 26 Aug 2015 03:08:52 -0400 Original-Received: from [194.166.87.107] ([194.166.87.107]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MCOdh-1ZczHm0uwr-009Bvq; Wed, 26 Aug 2015 09:08:51 +0200 In-Reply-To: X-Provags-ID: V03:K0:lDyZqoaOtJVTyPkv/49kJDysJ1R+pmtA/PTne11nv/SiHs6kEaW 8BVRV7Z9CIFnjNJcWaHxXrFzQRtvLCLodabj+m4L8zKRgt5abH9uwQ54yGZrtCRCPOmSEPN MIdmj7ShJ1vqX6DU4YzmienBH/UbDQIACk3IDqpBH6yKoPNPnNe+xEBHgMalOY1rvYS/cnP qWAicrWzLXe5st2wWmtqw== X-UI-Out-Filterresults: notjunk:1;V01:K0:hqHHEu3X15k=:df7YRe+FzZCWUkVAMEyZKE vg5hCpXg4k1GVZ9aP7Tkz+CnqxgzSAU7qD+7SjKfOq5VVKAgM9xg5N4uD4DsQvUKYQa1sf4LY 8mer6ROy94+2/STuEvi0bObkrjk7DvlJGToDjFFxhkUKKuRhB5LYREgywvMxenpNh0E2mT7ew EZVTQojiFn/Om+tUFYCwlmYNf2GyzMZ306dvQroE/B6TPfsAQmH6NowHDMT2VIdAU9jJEYjL8 njT93SqPNXmV4Kn8+xUCNEj/WyJRPsQpyyEHDLaTcqXizJOTxhiM4xXeaCKvIGuJ92HRPZT6k sInaB0M/XSrXeEiXi3gfMSZttxet1YwIRvLxgeq4oQYC+6oeu5GPjDVUvxMlvBD4CbFmRR99d 89fEVFZYS1eXQP2USAe/l58Tc3bAGA8h2/AjEnYtDU7XWWQtvD3DhDTpDdol88eSiMqoLfAKg h+nVoQ95vgWsLu3g5O8WlNuI4AV5wDTzAVOKWK9M5mB+U9UsI6vZUiRR2A3G6+JkVZl6oO/XV zQd0h3ulVn5JKs+fqBO9dRUDuut8ejSyUQfKIxmW6DGZXaz42xOlmcOrwzjDK1c/bBqcFVMi6 sfp7tALzRhSmaZLeGb65Ue0c6sj+i4b6fh7XV1iv+S6kR0DSLzG5LfJo51IYNQFyjc94xjcLg gI/MHUOXHnOQ0JdL+yEy6iafDlydFKL+ZFQOMKi03LRP+6zcnGhXxtTMXf9ZKykYT5DiorS3H A9k32f+OXHGoUX6PNhfnzqOZOcH+cxil4np7dg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105824 Archived-At: > I do think it would be best not to use set-window-configuration in > restoring state after exiting the minibuffer at all. I profoundly dislike window configurations but in this particular case they are needed. If the minibuffer gets enlarged, a window above it shrinks and as a consequence that window's start position changes to keep point on screen, it's important to restore the previous start position of that window. Everything else would be disconcerting. >> Alternatively, Fset_window_configuration could run a modified version= of >> =91compare-window-configurations=92 to compare the current configurat= ion >> with the one to be restored and restore the old configuration iff the= se >> differ. I'm not sure whether this would be any cheaper, especially w= hen >> the configuration does change frequently. > > I think it would be better to do this explicitly, even if we have to > compare all properties. You mean to compare the properties one can get by walking all windows on the frame with those of the configuration that shall be restored? Note that looking into a window configuration is not entirely trivial. > + if (!FRAME_WINDOW_SIZES_CHANGED (f)) { For consistency, please don't use hanging braces. > + if (w->pixel_left !=3D XFASTINT (p->pixel_left) || > + w->pixel_top !=3D XFASTINT (p->pixel_top) || Why do you think we need to check these? martin