From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#21333: 25.0.50; window-size-change-functions not called after mini-window resize Date: Mon, 24 Aug 2015 10:18:59 +0200 Message-ID: <55DAD373.7070700@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1440430630 32386 80.91.229.3 (24 Aug 2015 15:37:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Aug 2015 15:37:10 +0000 (UTC) To: Pip Cet , 21333@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 24 17:36:56 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTtnq-000306-Qm for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Aug 2015 17:36:55 +0200 Original-Received: from localhost ([::1]:53599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTtnl-0006si-9b for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Aug 2015 11:36:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTmz7-0001cq-Es for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 04:20:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTmz4-00022I-7o for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 04:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTmz4-000226-4J for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZTmz3-0004nz-R0 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 04:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2015 08:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21333-submit@debbugs.gnu.org id=B21333.144040434318396 (code B ref 21333); Mon, 24 Aug 2015 08:20:01 +0000 Original-Received: (at 21333) by debbugs.gnu.org; 24 Aug 2015 08:19:03 +0000 Original-Received: from localhost ([127.0.0.1]:36483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTmy7-0004md-6m for submit@debbugs.gnu.org; Mon, 24 Aug 2015 04:19:03 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:52113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTmy5-0004mN-S5 for 21333@debbugs.gnu.org; Mon, 24 Aug 2015 04:19:02 -0400 Original-Received: from [62.47.255.61] ([62.47.255.61]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M3AWN-1Ydc1L46aN-00swxx; Mon, 24 Aug 2015 10:19:01 +0200 In-Reply-To: X-Provags-ID: V03:K0:cXKemnAkoP/AqFXgrpE+OPyFlMGNypUFE4vyBg/jNOGSgCM+MgM Bq0wmh9iOh+tJxCYjV6nigq2TBHULt/t7AwwWrUhJHS3PK4cvYvnzJeHFYLj8+qHan+rILF sSYcjfToVMK5XZhpQ0sT72xmwOYlg5UI33HfgaKO+y5Sivn2xPNYgmGvFOjA7pFoinoeirL E43vtML+rAeACIWqJOPLw== X-UI-Out-Filterresults: notjunk:1;V01:K0:CGMWq+mNvq0=:RLDiXl3SX1dgp9pbBS0afD 1/29zYfOVfTIsOz9Qw1EWRF7zA1LFc7NEgtQ3nilEXPuVevGe+2Ojg4W3zIIcnFG97SZhbqan 0IeN/A6YasT+3N6TcvQuvr2rE8WZOVmlE9jucEMgsko9IcZzZF7J8TJWwlVs/JBMBc6ogCBR7 gFD4zjEesJrNTOv0fHP+JYiqhIZKkC+OzWt1R9x1VLzXRNbhzwOcaxbtfwGeGfxl5X0XdBfRY vSCglIbw728/EaMxb4BllZ+FpvTblFYKsVlBjHQDgNSkCDqnfOFwZWQVjsfYRVYST021tAnU3 GaAC6qLXNXL7Z654oYrE+e6qU2yeA0phIftU51DuT3Mi9I7ugxpJ0dTDE2uredxLe4qY8uKkf qXjuuqTVz4DezDlchAwshoWuNaAv0WPRHaaP3GdAx+nJY17Npvr5YRAwvZnNEal+Rs1KZb3L9 nEW5vLkr47bzjzGnGlgtaq1B2CzD8xM/nY/AmcRIeDbsRR0x53V6Gv4dL5H3IG6UZhDTKGH7j S2SAO2CxdlkXaDoLd8/eteqJkUtiD7aHhyiwCbQbbsKvNZCzKliT2/VDlO0/hACxwxoU/LMxD eItPx+D5WCl6fJBCU5qQ9Vene0xclM8RJp0elXEtsrAC5R0HNZLbZQutB76OFRn6giAOVBfTF byyMVNpM30E8uajN5xvpofjZ9clqyYdddPk4b3FRDBOu/ilqCOFQnlVCzzZ/U2rLpy3YLF9wf t6GNV932PpwmTutEBRYO+6hojr0l1ZSISPXWFA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105765 Archived-At: > This is possibly only a documentation issue. > > Recipe: eval > (progn (push (lambda (&rest args) (message "window size changed")) > window-size-change-functions) > (message (make-string 3000 ?*))) > > Expected result: a "window size changed" message. > > Actual result: no such message. > > > The symptom is that the window size change function is not run after a > mini-window size change. > > So far, I can produce this behavior only when the minibuffer or echo > area grows to several lines; when it shrinks afterwards, my window size > change function is called. I cannot reproduce the behavior with other > windows. > > Is this a bug? The documentation says: > > [...] to be called if the size of any window changes for any reason. > > Please correct me if I'm wrong, but when the minibuffer/echo area gets > resized (and the windows on top of it, too), that counts as a change of > size, I would say. > > If this is merely a documentation issue, the exception should be noted > in the manual. Looks like bug #830 23.0.60; window-size-change-functions sometimes not called in action. > Analysis: > First, some warnings: > - `window_resize_apply' and `Fwindow_resize_apply' (aka > `window-resize-apply') are two different functions > - `resize-mini-window' and `resize-mini-window-internal' are called > only when the mini-window is explicitly resized by a Lisp call of > `resize-mini-window'. Implicit resizes as a consequence of having > too much text in the echo area do not appear to call it. > > The problem is that FRAME_WINDOW_SIZES_CHANGED (f) is not set to true > after a mini-window resize. Fwindow_resize_apply would set this flag, > but window_resize_apply does not. > > If this behavior is deliberate, I believe it is inconsistent to set > FRAME_WINDOW_SIZES_CHANGED (f) in `resize-mini-window-internal'. > > > Suggested solution: > > Trivial. Add FRAME_WINDOW_SIZES_CHANGED (f) = true to all callers of > window_resize_apply. Your patch looks fine to me. I'd suggest to postpone installing it until your paperwork is complete. OK? Thanks, martin