From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9f31fb2: * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize. Date: Fri, 21 Aug 2015 20:09:22 -0700 Message-ID: <55D7E7E2.6010103@dancol.org> References: <20150821130356.5634.64124@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QT0xHoJWkSpQLLncjINGS2CUd3tAOUpob" X-Trace: ger.gmane.org 1440213005 31881 80.91.229.3 (22 Aug 2015 03:10:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Aug 2015 03:10:05 +0000 (UTC) To: emacs-devel@gnu.org, Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 22 05:09:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZSzBt-0001VB-3h for ged-emacs-devel@m.gmane.org; Sat, 22 Aug 2015 05:09:57 +0200 Original-Received: from localhost ([::1]:45236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSzBs-00042k-35 for ged-emacs-devel@m.gmane.org; Fri, 21 Aug 2015 23:09:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSzBf-00042M-KT for emacs-devel@gnu.org; Fri, 21 Aug 2015 23:09:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSzBc-0007C0-5G for emacs-devel@gnu.org; Fri, 21 Aug 2015 23:09:43 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:49344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSzBb-0007BB-Rr for emacs-devel@gnu.org; Fri, 21 Aug 2015 23:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:To:MIME-Version:From:Date:Message-ID; bh=+xUahNCf7rhdxuH3+kOAXnBNp3x+exfHr7LnuLk9s4U=; b=J+lX1YfCSXzwnaBh8zckwO34zypDVGbsL+ZBHZjodLRHRZso7lye8JS4sPyFgr10sB0ZUv18E6IKQCHkWpRffUYRAAAuS5JB/A3gI6+I7zL4+snUV9DOhuf0XyO7Tl/I6qzxahm+ELQo2i9KFx+Z86/wdrMYOVAaav3CPDecNCGuQBlXPuB5rRZ5RYX8tv0YyXZwde34CYMN4YLulDL7e+NJxG0wcwNLP7v8YTYysPMxRs4WqKK/ktyPiYlcZtGuh+iDG12sDKjGGfQ7GALA6ogs9T3kRyKRme7vNlGbHVDetd7cNv+3wfrlkVyNdqlDRb8d8+jsfk6u1OltKzW82w==; Original-Received: from [199.201.64.2] (helo=[172.26.5.100]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1ZSzBT-0007Ec-Vd; Fri, 21 Aug 2015 20:09:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189061 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QT0xHoJWkSpQLLncjINGS2CUd3tAOUpob Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 08/21/2015 06:03 AM, Stefan Monnier wrote: > branch: master > commit 9f31fb2a660a26ba510568fae102afc68db8f385 > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/progmodes/js.el (js-mode): Don't eagerly syntax propertize. > --- > lisp/progmodes/js.el | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el > index 40a4a10..98a22dd 100644 > --- a/lisp/progmodes/js.el > +++ b/lisp/progmodes/js.el > @@ -3560,9 +3560,10 @@ If one hasn't been set, or if it's stale, prompt for a new one." > ;; the buffer containing the problem, JIT-lock will apply the > ;; correct syntax to the regular expression literal and the problem > ;; will mysteriously disappear. > - ;; FIXME: We should actually do this fontification lazily by adding > + ;; FIXME: We should instead do this fontification lazily by adding > ;; calls to syntax-propertize wherever it's really needed. > - (syntax-propertize (point-max))) > + ;;(syntax-propertize (point-max)) > + ) > That call is needed for correctness, as I recall. Are you replacing it with something? --QT0xHoJWkSpQLLncjINGS2CUd3tAOUpob Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJV1+fiAAoJEN4WImmbpWBluroP/3PQGDnvCw5uxPudhSVxZ41P UDex6W8hMIq1SddlLP55qsTrnEChNe2ur7fhua0D8IyVngyj9AX4YKuHrr7njnov g4h9DKFm/MmrrZVkBuEEpfdMYCasOMiyuTzS7VOfFF7QfT3QGfepRGBBd+umftlG 7NIFKDulsLdKokaeBqjONA8MZ/KttKdfZi4qgFb5AYws5pgb0h+kvartNPrj3n9M D1lfGcNnNjnEYB6nsZnGjB+x5+nYGQcp9t03x85ryUV2rAEvDglOqAekfi53iOYB Pbkttf9fMpHeAtNsISR6dpWligRuSJix+jRda74K4U95jyGskCX+1BdS271k6s/I 7rpS7tLTtEa4no3vtFeqM5nKAAV7ghqrOojUS9Bsahz2+tHgVkY08ognNdKmrG6n 0kW1xGvjxWr5uUIe3lqWUsGvG+k+WBfR+/1afvI5INHQL5cLJcQNaaWA/ATBPujj xKdXiCfncbxiZd6biceP8WLtM31Z4KSijUpBy6vUSyO/ux6XYt3g7ffQKXGoewee mo7Rqhar7hVABggpcOJKdcmCuHksGVpka7wC8n5joyb1ccubSC/L/l97BQDADCzY Xo14MThPwM+FlBGimqyQ92XvlWc1iXSXYiOwJv71RJGPNBaB0q0bcDy1futklF1v Q+DBzJoNjZUwKsfYZlZA =n/FS -----END PGP SIGNATURE----- --QT0xHoJWkSpQLLncjINGS2CUd3tAOUpob--