From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: xref--read-identifier should call project-identifier-completion-table? Date: Mon, 3 Aug 2015 12:56:14 +0300 Message-ID: <55BF3ABE.3020505@yandex.ru> References: <86k2tchfem.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1438595792 10017 80.91.229.3 (3 Aug 2015 09:56:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2015 09:56:32 +0000 (UTC) To: Stephen Leake , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 03 11:56:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMCTu-0007Mw-Rs for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2015 11:56:31 +0200 Original-Received: from localhost ([::1]:58407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMCTu-0001a3-6j for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2015 05:56:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMCTq-0001Zw-UM for emacs-devel@gnu.org; Mon, 03 Aug 2015 05:56:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMCTl-0004dp-V9 for emacs-devel@gnu.org; Mon, 03 Aug 2015 05:56:26 -0400 Original-Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:38700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMCTl-0004dl-OV for emacs-devel@gnu.org; Mon, 03 Aug 2015 05:56:21 -0400 Original-Received: by wibxm9 with SMTP id xm9so106712115wib.1 for ; Mon, 03 Aug 2015 02:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=g62xflFmFcjzN2Ov6R51v+1rKIAt3+tOlBNzMuk1rQM=; b=Rs/L3DLLnXe3cUFrYks+klBQX+FGZJ7fgLXrPlyXDneO2AdHxhTfYzZiOTpNyHcHU3 IDhxRYymc9fVBVOrcWpWt7cyrliiwZROXeSszeZTg1VHBFntyicsu3ieiKxbdScp1FPo 8nRdJD77KNU0gLu+ZXQlZtzCp9kQOSqtvr6G9r9M42Q5zcgsj04TP3ajqiPFL999j343 3fmX4aoP9kc61QkAHTblvITnWPr2hRIVuTsc4X07r3/OOTFru4RU8ahbvshPiMeQYwsQ HYwcgwsBXo5eNQHlmh713qH1RrHUR4+2GHtdbb+pTufRhm4JSDJ4DZEoqKdsDqgK6LBq 7AkQ== X-Received: by 10.194.187.40 with SMTP id fp8mr7696405wjc.34.1438595781010; Mon, 03 Aug 2015 02:56:21 -0700 (PDT) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id nb9sm12713789wic.10.2015.08.03.02.56.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 02:56:20 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Thunderbird/40.0 In-Reply-To: <86k2tchfem.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188325 Archived-At: On 08/03/2015 12:47 PM, Stephen Leake wrote: > The default method for project-identifier-completion-table uses the > current xref buffer-local variable, so that's the same as the current > behavior. It might be better to change that to have a project- prefix. What's the use, if the rest of the operations still use the buffer-local value of xref-find-function? You'll get Elisp identifiers in completion, but won't be able to navigate to them. The natural extension of this approach would be to have a project-xref-backend accessor, but do we really need that? The same minor mode that enables your project globally could set xref-backend (the variable is still called xref-find-function, but not for long) in all buffers. It'll actually be a list, so you'll put an always-active element at its head, just like with project-find-functions.