From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defgeneric vs random funcall in project.el Date: Wed, 29 Jul 2015 22:54:30 +0300 Message-ID: <55B92F76.7060104@yandex.ru> References: <86oaiwa57v.fsf@stephe-leake.org> <55B79B3F.1060200@yandex.ru> <86wpxj93r2.fsf@stephe-leake.org> <55B82A0C.5040709@yandex.ru> <86fv4782k2.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1438199691 6580 80.91.229.3 (29 Jul 2015 19:54:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Jul 2015 19:54:51 +0000 (UTC) To: Stephen Leake , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 29 21:54:50 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZKXRC-0001rd-Ch for ged-emacs-devel@m.gmane.org; Wed, 29 Jul 2015 21:54:50 +0200 Original-Received: from localhost ([::1]:36798 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKXRB-0001RZ-LA for ged-emacs-devel@m.gmane.org; Wed, 29 Jul 2015 15:54:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKXR0-0001R1-SX for emacs-devel@gnu.org; Wed, 29 Jul 2015 15:54:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKXQw-0003Ft-Tb for emacs-devel@gnu.org; Wed, 29 Jul 2015 15:54:38 -0400 Original-Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:36545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKXQw-0003Fd-MF for emacs-devel@gnu.org; Wed, 29 Jul 2015 15:54:34 -0400 Original-Received: by wicgb10 with SMTP id gb10so215331391wic.1 for ; Wed, 29 Jul 2015 12:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=z+sp9EFFRcD+G8hVbEWdXFDuXPvprhAHeaJQWIYHpOY=; b=GMDZGaoKBOkxpJjYW38WVpemgoY12oA6ebLwjss3tHKJXSg/UrAbPaxGfBPKVgTblh V0jjT7LrkZNrUb1vUck3wGWefXJhK1ac0WpP7lKNxeHN8pkb6faprkuEoSmt1zQu5cZM nl/vFFGcIP28IGko+yOP2gnzrU9KJaT7E/Bq2uVxG7tDbJv+HslcT8DBUmm71o+8XUnA fG5USWEgmdNTF7xTdXO9asM1PHTrJ0L4RM71GagoNRZejKmXuNtEVzS8Z5w737J7CuuE xoHEuy+H3D1pk+Ii2tWUrVBplABokbVhqYgu6dSCqQo7G8RVjr7hRh5A/pFcH1B8sjf1 GHRQ== X-Received: by 10.180.85.194 with SMTP id j2mr20384493wiz.11.1438199673162; Wed, 29 Jul 2015 12:54:33 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id v20sm40194797wjw.17.2015.07.29.12.54.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 12:54:32 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 In-Reply-To: <86fv4782k2.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188174 Archived-At: On 07/29/2015 05:24 PM, Stephen Leake wrote: >> """ >> So some specific change proposals: >> >> - Rename 'project-directories' to 'project-root-directories' or >> 'project-roots'. The current project root should always be first in >> the list. >> >> - 'project-search-path' should not include 'project-root-directories'. >> """ > > That means the _code_ for default method for the function > project-search-path should not append the value of the result of the > function project-root-directories. It was my mistake, then. I hope, though, after rereading that message, you can agree that it was an easy one to make. > The point was I thought that project-search-path and project-directories > were distinct concepts, not related to each other. The contents may > overlap, or either one may not be defined. Try to imagine the consequences of project-search-path having to include project-roots, or even some directories within them. Take emacs-lisp-mode, it makes project-search-path return load-path, through project-search-path-function. Now, take an actual project implementation, like the one returned by project-try-vc. It doesn't know anything particular about Elisp, but there might be some directories with Elisp code inside the current project tree. There's no guarantee that they're added to load-path, at any given time. Should the VC project provide its own implementation of project-search-path? > Now that I see that you intended them to mean project-path-read-only and > project-path-read-write, things have changed. These are pretty bad names, though.