From: martin rudalics <rudalics@gmx.at>
To: Greg Minshall <minshall@acm.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: unsolicited patch to image-mode.el -- "fit to window"
Date: Sat, 25 Jul 2015 10:27:35 +0200 [thread overview]
Message-ID: <55B34877.2070406@gmx.at> (raw)
In-Reply-To: <39315.1437728590@greg-minshalls-mbp.local>
> right, that seems like a good rule to me. so, i'd tend to leave my code
> with the same pattern used in the rest of the file (i.e., using
> (window-size-pixel-edges)), just for consistency.
I don't understand the "so" ;-)
> (but, even a very
> light breeze would be enough to cause me to change it to use the clearer
> calls, so feel free to so breathe.)
I can't test your patch because I build without image support. But I
have two questions: (1) Why can't you use `fit-window-to-buffer'? (2)
If the image appears on a frame alone, can you fit the frame to the
image? Can `fit-frame-to-buffer' fit the frame to the image? Both of
these should work, in principle.
martin
next prev parent reply other threads:[~2015-07-25 8:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 16:50 unsolicited patch to image-mode.el -- "fit to window" Greg Minshall
2015-07-12 16:56 ` Zack Piper
2015-07-13 5:19 ` Greg Minshall
2015-07-14 23:23 ` Stefan Monnier
2015-07-23 17:52 ` Greg Minshall
2015-07-23 18:26 ` martin rudalics
2015-07-24 3:46 ` Greg Minshall
2015-07-24 5:30 ` martin rudalics
2015-07-24 9:03 ` Greg Minshall
2015-07-25 8:27 ` martin rudalics [this message]
2015-07-25 8:31 ` martin rudalics
2015-08-19 14:17 ` Ted Zlatanov
2015-08-06 22:28 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B34877.2070406@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=minshall@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.