From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: unsolicited patch to image-mode.el -- "fit to window" Date: Fri, 24 Jul 2015 07:30:52 +0200 Message-ID: <55B1CD8C.3010203@gmx.at> References: <38598.1437709588@greg-minshalls-mbp.local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1437715881 7838 80.91.229.3 (24 Jul 2015 05:31:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jul 2015 05:31:21 +0000 (UTC) Cc: emacs-devel To: Greg Minshall Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 24 07:31:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZIVZf-0001DS-L9 for ged-emacs-devel@m.gmane.org; Fri, 24 Jul 2015 07:31:11 +0200 Original-Received: from localhost ([::1]:43679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIVZe-0001qt-RA for ged-emacs-devel@m.gmane.org; Fri, 24 Jul 2015 01:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIVZc-0001qk-8Z for emacs-devel@gnu.org; Fri, 24 Jul 2015 01:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIVZZ-0000Kn-3l for emacs-devel@gnu.org; Fri, 24 Jul 2015 01:31:08 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:58639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIVZY-0000Kh-Rl for emacs-devel@gnu.org; Fri, 24 Jul 2015 01:31:05 -0400 Original-Received: from [62.46.208.120] ([62.46.208.120]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MXIcX-1ZNi7d3Sfl-00WHZd; Fri, 24 Jul 2015 07:31:00 +0200 In-Reply-To: <38598.1437709588@greg-minshalls-mbp.local> X-Provags-ID: V03:K0:6MfBlgj2lirWGdw670UsyAw4hHJKjQiCMLzfk+G+LaMA9Y9fVDB MKOICVDgt9rtaXOz9RPWyN1Vb1LPOTBXs0CPF5ug1r3h+ZsSMn+7eMRkJTlF/zCOX1ZBY/Y AlgRjrBI1BJMPm7ExD7rlGjv8QueFFLG+H+72hu7R7iJAMRJc3ptYX7fH/Q6kT3QvQyHbhg 8Bvk9lIwiugDmm271eUyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9FMm02axBe4=:MViKWi7tfYB7/oxVmRANuZ 0yG7d8JnNlD8921TRFR7YKQGFW4l0MbVQYaOui7uLQ83yKHd17tdxsas8na8a//oiK/IFVyaq HVGM9fUI7hoAefoYFMxdLCiBBhxDl4AaWmA6IciyikR5sgkcQk11mQJIFKiS+vwH4S02+DwW4 MmWHC0TFH4ZPO8heIfRzijkiku+zwUUuX4xjsXwfz0NI/ErOjs/kop2JmmaewsunFASfNHOjj qILBxCyLM+MiOW/xioAZXVj0ooCfFsWhwo8LB2efBvwdOA0bq5qKZzp4tlnqTAciRQ7gGQ8UI zx0AjcjEuTb4NmGE7ZSR2pnhO/l6cyDfDZBbUrjwm27P8T1GFa4MSV9PjQiERQtRw/eyTTfK9 MM5pH22JfWS52mFvohGTxk5Nos/76eFktBeefM4878bIyiZrnujJvOBDUJSCKN/1pdhzDL80e eOTDk3ve1i/ClSBKSLW5hTfVwL/opeKqrpclsPAqgdckZ/Y/ApMJKi9PRnDK/qunoLaht1YVY at7W5XJskT1cF9zMB+EmsS0kqDjXw8eReWA+kQr02/JpCZYMAME8z46YF9zsHfaLCaQfnuYtl A/M1ZahLgcBlOtt2LPzdbNBOQCqaaTTE92SGG18LVTGf9tvPlzkiu7ucWG93XwUwVrt7UloSv SRWV7x1GAg8RrbpZvrGV7te5x+0ocHYeZphZaO4Jh5v7UwKK+gdwyYIyQbiqXTDum8Og= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188045 Archived-At: > a "coding philosophy" question, though. there are a dozen or so other > references to (window-size-pixel-edges) (and its associated (nth)'s) in > the code. my tendency would be to change none (in a patch) or all (in a > more substantive re-write). changing all -- while "trivial" -- is, of > course, more likely to introduce bug, and i don't know of any test suite > for image mode? If such code is not buggy, it should be changed only when and only by the person(s) working on it. Otherwise, as you say, it's too easy to introduce a bug in code that was correct before. martin