From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob Date: Sun, 19 Jul 2015 14:05:04 +0300 Message-ID: <55AB8460.6080707@yandex.ru> References: <85lheh8ekr.fsf@iznogoud.viz> <55AAEA7C.2060609@yandex.ru> <85380ludu0.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1437303981 16895 80.91.229.3 (19 Jul 2015 11:06:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jul 2015 11:06:21 +0000 (UTC) Cc: 21067@debbugs.gnu.org To: Wolfgang Jenkner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 19 13:06:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZGmQ6-0006nq-C4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jul 2015 13:06:10 +0200 Original-Received: from localhost ([::1]:51054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGmQ5-0003d3-9b for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jul 2015 07:06:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGmQ1-0003cx-R8 for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2015 07:06:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGmPy-0008KK-KC for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2015 07:06:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGmPy-0008JO-Fy for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2015 07:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZGmPy-0003rj-0Q for bug-gnu-emacs@gnu.org; Sun, 19 Jul 2015 07:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2015 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21067-submit@debbugs.gnu.org id=B21067.143730392014812 (code B ref 21067); Sun, 19 Jul 2015 11:06:01 +0000 Original-Received: (at 21067) by debbugs.gnu.org; 19 Jul 2015 11:05:20 +0000 Original-Received: from localhost ([127.0.0.1]:53571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGmPI-0003qp-3N for submit@debbugs.gnu.org; Sun, 19 Jul 2015 07:05:20 -0400 Original-Received: from mail-wg0-f44.google.com ([74.125.82.44]:36410) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGmPE-0003qb-Av for 21067@debbugs.gnu.org; Sun, 19 Jul 2015 07:05:17 -0400 Original-Received: by wgbcc4 with SMTP id cc4so17995602wgb.3 for <21067@debbugs.gnu.org>; Sun, 19 Jul 2015 04:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=kdE73L8oLkKbw4izYfK3Ic4qFbRqKKsMc4dDi5SJPpo=; b=QBrLzzISnzfCs5RVYcP++7CymE1OKpKA7WVFBQsp6vz0mc1jMSUWwQke8PDl44r6Tu 8/EC3CY5HgOWI3/oj5Nj2j3n/xfvcDjJWRMJBbItJGouamUeQKbR1HNIuBYU6i9LqNb4 BaWn2Iy170+YhAX5U9/atFM3qCBNZ8XD1X9q+PzlQFO926ekIlh2NsmV+zEI7R43PZn/ gr36LoKZT5NoFEHZ/DiveIX+mujq2az8yVoH7neJhooZ78yc6RUnLGfA6YMKI83KcRAD abJ//of+eqwZfa7weevONwIUysIs2gBKHHfCtZtuvW9vl4AXMWAbUGKtfnbeVh3V6Xvj DGyg== X-Received: by 10.180.218.195 with SMTP id pi3mr11802994wic.71.1437303910730; Sun, 19 Jul 2015 04:05:10 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ez4sm6539982wid.14.2015.07.19.04.05.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2015 04:05:09 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 In-Reply-To: <85380ludu0.fsf@iznogoud.viz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105036 Archived-At: On 07/19/2015 04:36 AM, Wolfgang Jenkner wrote: > If I read diff-hl-revert-hunk correctly the code in vc-exec-after > expects point where (the synchronous call to) vc-diff-internal left it, > which should not be at eob, which is exactly where my patch would put > it :-( It's not hard to fix, though: (goto-char (point-min)) at the beginning of vc-exec-after block there should do it. That would be backward-compatible, so I'm perfectly willing to make that change. > It seems some code (not so far) out there uses synchronous calls for > a reason and also does much more weird things in vc-exec-after than I'd > have thought. There are not too many third-party packages that integrate with VC, so one could go over them and check for similar assumptions. Your patch does make a certain amount of sense. > If all -print-log backend functions can be made asynchronous there's > nothing left to fix in the frontend I guess... They can, but a similar problem could conceivably arise with something other than print-log. On the other hand, the long-term target is to make all VC calls asynchronous. So maybe we can take the easy way out in fixing the present bug.