From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Devlin Newsgroups: gmane.emacs.bugs Subject: bug#68805: 29.2; Tramp: out-of-band copy-file fails when tramp-copy-keep-date is nil Date: Thu, 1 Feb 2024 10:34:36 -0500 Message-ID: <55A934E6-19B9-4EFC-BA64-25F35E4115B4@toadstyle.org> References: <59B29F53-DEE4-4DDD-BC68-8BB16652633E@toadstyle.org> <87frycgvo7.fsf@gmx.de> <87a5okguqo.fsf@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.141\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21258"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68805@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 16:36:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVZ6p-0005Lo-Gp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 16:36:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVZ6a-0003hl-CN; Thu, 01 Feb 2024 10:35:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVZ6W-0003hc-Ss for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 10:35:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVZ6W-0001L9-6K for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 10:35:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVZ6g-0007XS-4t for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 10:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68805 X-GNU-PR-Package: emacs Original-Received: via spool by 68805-submit@debbugs.gnu.org id=B68805.170680170928906 (code B ref 68805); Thu, 01 Feb 2024 15:36:02 +0000 Original-Received: (at 68805) by debbugs.gnu.org; 1 Feb 2024 15:35:09 +0000 Original-Received: from localhost ([127.0.0.1]:43017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVZ5p-0007WA-65 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 10:35:09 -0500 Original-Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:47397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVZ5j-0007VN-Qt for 68805@debbugs.gnu.org; Thu, 01 Feb 2024 10:35:07 -0500 Original-Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-78407987510so53911385a.3 for <68805@debbugs.gnu.org>; Thu, 01 Feb 2024 07:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20230601.gappssmtp.com; s=20230601; t=1706801688; x=1707406488; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DmDFcFjbM58fsOlOqvi+24NAL/PcFIYuIktvrr6rPYc=; b=oxViL4AvwdKEbZhzHl26g2a+f6+RbjpZDq0MoLlNyCbB7TfbtPEweGmJ5DjOsBz1vG /DTyBRyW6CILNmUjZ+MlQMUs5Z6fzuUoOiiCDUmUIm+tE0+b3FiexTZediz51Y7f1Tit UMAkBoaJizpHe7Hxocjp6SOUrYZRapPC+Q7e+uBHUdYHsGUkw1mMhFHLgZ/or/3TQqDz RgVX66Kk0zme422LL/+lmXE832RZ9pd2imeA6fUSUyEBpX8HkK+L0YyF+2Ok8hYS13yl oUW55d1wjsBKKWvNP0hT+TtmmqYXf/MVjJHI6HeBLkWgm19DiE93x1gW2MD+6kySuU3I b+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706801688; x=1707406488; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DmDFcFjbM58fsOlOqvi+24NAL/PcFIYuIktvrr6rPYc=; b=uPAja8VcNNMhcxGuQrkPgGKDp1pVDDAvYS6fXrTKr509bGU7UqRiC9yB+bRBTldC7e Nc+Dek9r+UtRr6kJMiL0o6MJAKNAWA0stpAVFNmPOPhWxsZE8BVJ0ON6tTcfTenXJQRl pHknOf2lrfntitjRcJyUXFjld84+ssTpdkckNvNDssE3xexY+dL9ud6KdrKUIgwNRbJN df7L3agV1+aYXksiI3IDVgWE+Scx+KAPbUdlxBSMbkkQNJSTzXnMnL9B0B524fLH/yJA Df5sFP9pClj7Fv/s12HoHc7fmHWLtRryO8MNXrUxrZUO48cX6e/yQ6PMt2CNUNujeyE0 BX6A== X-Gm-Message-State: AOJu0Yz+a1dlEPKAE+8BMLG1ntJ2a9/Lv/CdKxL/a1U648yI9L0vsi6F CxtHGYO3NLn51I1h9Wet/n6LWtgX4zZ+kzv2oCDgZ9Rzm03E/01gvwYMo6KGfhWhPb42d8QoiK/ W X-Google-Smtp-Source: AGHT+IHvsrzFSDE/skB9J9YtBJuUhuzuj6StY4jPVDjBj0+MW46bcIOYlqBNvGLXR8THMYLcRcpVrw== X-Received: by 2002:a05:620a:4594:b0:783:8c5b:8d1b with SMTP id bp20-20020a05620a459400b007838c5b8d1bmr3140548qkb.14.1706801687908; Thu, 01 Feb 2024 07:34:47 -0800 (PST) Original-Received: from smtpclient.apple ([17.44.248.117]) by smtp.gmail.com with ESMTPSA id s17-20020a05620a031100b0078403269190sm3027724qkm.36.2024.02.01.07.34.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Feb 2024 07:34:47 -0800 (PST) In-Reply-To: <87a5okguqo.fsf@gmx.de> X-Mailer: Apple Mail (2.3774.500.141) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279295 Archived-At: Hi Michael, I can confirm the below patch fixes the issue. Thanks for your help! Regarding the comment, couldn=E2=80=99t some cached file properties = (i.e. other than file-exists-p) be wrong even if NEWNAME did already exist? I haven=E2=80=99= t really thought this through, just curious. Thanks! > On Feb 1, 2024, at 8:49=E2=80=AFAM, Michael Albinus = wrote: >=20 > Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife = of > text editors" writes: >=20 > Hi Sean, >=20 >> Thanks for the report and the analysis. It is correct. Could you = please >> check, whether this patch fixes it: >=20 > Oops, that's too lax. Pls try the following instead: >=20 > diff --git a/lisp/tramp-sh.el b/lisp/tramp-sh.el > index 1301cd63..44c0bdc7 100644 > --- a/lisp/tramp-sh.el > +++ b/lisp/tramp-sh.el > @@ -2521,6 +2521,12 @@ The method used must be an out-of-band method." > ;; cached password). > (tramp-cleanup-connection v 'keep-debug 'keep-password)))) >=20 > + ;; The cached file properties might be wrong if NEWNAME didn't > + ;; exist. Flush them. > + (when v2 > + (with-parsed-tramp-file-name newname v2 > + (tramp-flush-file-properties v2 v2-localname))) > + > ;; Handle KEEP-DATE argument. > (when (and keep-date (not copy-keep-date)) > (tramp-compat-set-file-times >=20 > Best regards, Michael.