From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183)
Date: Thu, 02 Jul 2015 20:00:26 +0200 [thread overview]
Message-ID: <55957C3A.7020909@gmx.at> (raw)
In-Reply-To: <jwvlheyttj8.fsf-monnier+emacsdiffs@gnu.org>
>> You mean the defcustom for `window-divider-mode'? Then I completely
>> miss you. Where would I specify the permitted values?
>
> The minor mode only allows two values (enabled/disabled).
> So you'll need a second variable specifying what the "enabled" state
> should look like.
But how would a user customize switching from the `right-only' to the
`bottom-only' state? How would a user specify the preferred initial
state?
I initially wanted to add just a simple menu entry for switching. For
that I wanted an option which allowed to select one of four permissible
states. Obviously, that option would have to be customizable via the
`customize-variable' interface as well.
Then I noticed that all items in the Show/Hide group are minor modes.
Some of them in a contorted sense - both `fringe-mode' and
`mouse-avoidance-mode' are simple defuns. I would have preferred to do
it their style, possibly using completing read. But I tried to be a
good citizen and specified `window-divider-mode' in a sense similar to
`scroll-bar-mode' - the only mode I found that was specified via
`define-minor-mode' and allowed more than two values.
Now if I'm not mistaken you seem to say that the approach I've chosen is
not TRT. But how can I know what TRT is? Neither the various modes one
can activate via the menu bar nor the manual provide useful guidance in
this regard :-(
martin
next prev parent reply other threads:[~2015-07-02 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150702070503.30720.41171@vcs.savannah.gnu.org>
[not found] ` <E1ZAYYS-00081G-Fb@vcs.savannah.gnu.org>
2015-07-02 13:55 ` [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183) Stefan Monnier
2015-07-02 16:05 ` martin rudalics
2015-07-02 16:28 ` Stefan Monnier
2015-07-02 18:00 ` martin rudalics [this message]
2015-07-03 1:50 ` Stefan Monnier
2015-07-03 13:20 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55957C3A.7020909@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.