From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20926@debbugs.gnu.org, bruce.connor.am@gmail.com
Subject: bug#20926: 25.0.50; Quotation marks always display as hard quotes
Date: Thu, 02 Jul 2015 09:34:44 -0700 [thread overview]
Message-ID: <55956824.3000002@cs.ucla.edu> (raw)
In-Reply-To: <83fv561usi.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Eli Zaretskii wrote:
> messages and documentation displayed in batch mode might be illegible
> on some text terminals.
Thanks, I hadn't thought of that, and overoptimized. Easy enough to do the
check even if -batch. I installed the attached patch.
> How is the locale's codeset relevant here? The issue was encountered
> in a GUI session, where that should be unimportant.
Yes, but the bug was that Emacs hadn't initialized the GUI yet and so
char-displayable-p acted as if in a tty session.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-batch-should-not-affect-display.patch --]
[-- Type: text/x-diff; name="0001-batch-should-not-affect-display.patch", Size: 1603 bytes --]
From 28217db57c7f1853a4c98ed0a32c2051a2a37807 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 2 Jul 2015 09:29:51 -0700
Subject: [PATCH] =?UTF-8?q?-batch=20should=20not=20affect=20=E2=80=98?=
=?UTF-8?q?=E2=80=99=20->=20`'=20display?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lisp/startup.el (command-line): Do the ‘’ -> `' check even if
-batch (Bug#20926).
---
lisp/startup.el | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/lisp/startup.el b/lisp/startup.el
index 4f1e315..cfe2269 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1018,12 +1018,11 @@ please check its value")
(setq no-blinking-cursor t))
;; If curved quotes don't work, display ASCII approximations.
- (unless noninteractive
- (dolist (char-repl '((?‘ . [?\`]) (?’ . [?\']) (?“ . [?\"]) (?” . [?\"])))
- (when (not (char-displayable-p (car char-repl)))
- (or standard-display-table
- (setq standard-display-table (make-display-table)))
- (aset standard-display-table (car char-repl) (cdr char-repl)))))
+ (dolist (char-repl '((?‘ . [?\`]) (?’ . [?\']) (?“ . [?\"]) (?” . [?\"])))
+ (when (not (char-displayable-p (car char-repl)))
+ (or standard-display-table
+ (setq standard-display-table (make-display-table)))
+ (aset standard-display-table (car char-repl) (cdr char-repl))))
;; Re-evaluate predefined variables whose initial value depends on
;; the runtime context.
--
2.1.0
next prev parent reply other threads:[~2015-07-02 16:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 12:42 bug#20926: 25.0.50; Quotation marks always display as hard quotes Artur Malabarba
2015-06-29 12:48 ` bruce.connor.am
2015-06-29 13:14 ` Artur Malabarba
2015-06-29 15:02 ` Eli Zaretskii
2015-06-29 15:10 ` Artur Malabarba
2015-06-29 15:22 ` Artur Malabarba
2015-06-29 15:32 ` Eli Zaretskii
2015-06-29 15:38 ` Artur Malabarba
2015-06-29 16:18 ` Artur Malabarba
2015-06-29 16:57 ` Eli Zaretskii
2015-06-29 19:23 ` Artur Malabarba
2015-06-29 14:56 ` Eli Zaretskii
2015-06-29 15:08 ` Artur Malabarba
2015-07-02 5:42 ` Paul Eggert
2015-07-02 10:12 ` Artur Malabarba
2015-07-02 14:11 ` Paul Eggert
2015-07-02 14:46 ` Eli Zaretskii
2015-07-02 16:34 ` Paul Eggert [this message]
2015-07-02 16:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55956824.3000002@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=20926@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.