From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183) Date: Thu, 02 Jul 2015 18:05:10 +0200 Message-ID: <55956136.4040409@gmx.at> References: <20150702070503.30720.41171@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1435853921 10847 80.91.229.3 (2 Jul 2015 16:18:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Jul 2015 16:18:41 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 02 18:18:33 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZAhC4-0003vo-NH for ged-emacs-devel@m.gmane.org; Thu, 02 Jul 2015 18:18:32 +0200 Original-Received: from localhost ([::1]:37458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAh04-0005uJ-HL for ged-emacs-devel@m.gmane.org; Thu, 02 Jul 2015 12:06:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAgzL-0005pY-Kw for emacs-devel@gnu.org; Thu, 02 Jul 2015 12:05:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAgzI-0002Pw-De for emacs-devel@gnu.org; Thu, 02 Jul 2015 12:05:23 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAgzI-0002Pg-22 for emacs-devel@gnu.org; Thu, 02 Jul 2015 12:05:20 -0400 Original-Received: from [62.46.214.51] ([62.46.214.51]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lhfu5-1YfjsC2Wsj-00mvaX; Thu, 02 Jul 2015 18:05:17 +0200 In-Reply-To: X-Provags-ID: V03:K0:NlSSUPzSOCvM7UYGmjhdY4FStysanDChsvvjKV0xLDs15IYhqr2 6MgA+NN4dYAVJ6yZRDR5IhvxbmeVENabybRQNqtjx56Ly6kcjGXt7UR+2xyakCcIpaXO8Dy QXqXKgE0A4gOkzO0yV5oMhugYHuT2HEOX+/RbS8dWdW4gKnSp1W0JlAdMioluHe7lUkMEOI efAcQawAzHCVq1Hs94KDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nUC9r+QwMEs=:3w3u71Y2Ql0q0WZ0i+rHuc uxYARAJxr9DnUenAsj1zpSpmCBNo1WPS0tKsaxcehcBtEUHMvCStemUZySRX/hij6DffVuV8h jSPaUOrqUBsYg4dPrn1+NVV270RP5tq8IBUiJlBn0h3OT+WVOlr8OSNcr8ZQASFNBYgLuFJFC 7R6ew9ciInGLIdHiDxqsDwtQGSE0+Vylvo5/ULp+CYiEA/2WLxb6CyfvvtLokvAOPGkIZCtTC gRclastwcYtUa39liKlyfURNxzZIQoxZXdueRNViwFGhc5YHkokVWv01d3BeTQG21zxi4WaiT CDZKuDQqYXPLRYIervmJ2mAhIK0cGOGM4dD4uFHPWny80UWhWIQCEguvhnXvXc+JOjdiyLqdC cEq4mWJPwFz57gmZV5nGVEY+8K+Z16FypTHAaPhy9Urp9/nnu3IHqRuweIUu9DBtLFpLzQhgh NZ0MDZinA9pTYziAbqKquj8X5bE2w9O5r10XZ+53YL9l6+8IuO141dKJv7NsGr+ZU6c4yC2iO yNoFL5LHoY3INQvA+OTnATrpCW51M7nHO3Xn9RDfX0s3NjsO1GypjJ3usRPA/RBYCrYQxRump ygf2GkOM6BVI0eIpC2Z2m3FGZYXZExg1tRqTeHJfnVVoj3uwO0wYlP63k1NLH+WpLlhPKtYEU YOsCc33DmFcZVTYVrs2ETj+tHivJCSnEZbffBwcalSr2497szinQ15nqXbiP+InvyiMU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187713 Archived-At: >> +(defgroup window-divider nil > [...] >> +(defcustom window-divider-mode nil > [..] >> + :group 'window-divider > > This :group is redundant since it refers to the last created group. Interesting. Is this documented somewhere? >> +(define-minor-mode window-divider-mode > [...] >> + :group 'window-divider >> + :global t >> + :variable (window-divider-mode >> + . (lambda (value) >> + (frame--window-divider-mode-set-and-apply >> + (and value >> + (or frame--window-divider-previous-mode >> + (default-value 'window-divider-mode) >> + 'right-only)))))) > > I'd rather not abuse the (GETTER . SETTER) here. This is only really > needed for those cases where the value of the mode is neither kept in > a global var nor a buffer-local var (e.g. it's kept in a window or frame > parameter instead). > > So, we should drop :variable, which will also let us drop the > separate defcustom. You mean the defcustom for `window-divider-mode'? Then I completely miss you. Where would I specify the permitted values? martin