From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20728@debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Mon, 29 Jun 2015 19:11:19 +0300 [thread overview]
Message-ID: <55916E27.3010200@yandex.ru> (raw)
In-Reply-To: <83twtq4jtd.fsf@gnu.org>
On 06/29/2015 06:26 PM, Eli Zaretskii wrote:
>> On the other hand, we might want to choose to set
>> `grep-highlight-matches' to `always' in grep-compute-defaults,
>> irrespective of the OS.
>
> Won't that bring back the problem in symref/grep.el again?
Why would it?
The replace (replace-regexp-in-string "--color=always" ...) call is
still there. I didn't change that because CEDET supposedly needs to
retain compatibility with previous Emacs versions.
But there is a similar function: xref-collect-matches.
Looking at it now, I forgot to apply a relevant fix to it (and this is
an example of a Lisp code author doing the wrong thing because `auto'
happened to make things right anyway, on my machine). So could you:
- Try M-x xref-find-regexp on a Windows machine (in an Elisp buffer,
enter something like "xref-find-").
- Probably see it fail for the same reason as symref/grep.el did previously.
- Apply the patch below.
- Hopefully see it succeed and write back about that.
> Assuming we can count on commands that live far away, like
> symref/grep.el, to make a point of doing this, it will work, of
> course.
The idea is to force their authors to do it (because the commands won't
work otherwise).
Patch:
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 50d52d0..bb2546f 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -749,8 +749,10 @@ tools are used, and when."
(require 'semantic/fw)
(grep-compute-defaults)
(defvar grep-find-template)
+ (defvar grep-highlight-matches)
(let* ((grep-find-template (replace-regexp-in-string "-e " "-E "
grep-find-template t t))
+ (grep-highlight-matches nil)
(command (rgrep-default-command (xref--regexp-to-extended regexp)
"*.*" dir))
(orig-buffers (buffer-list))
next prev parent reply other threads:[~2015-06-29 16:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 23:42 bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Dmitry Gutov
2015-06-04 2:43 ` Eli Zaretskii
2015-06-04 8:58 ` Dmitry Gutov
2015-06-04 15:01 ` Eli Zaretskii
2015-06-04 15:18 ` Dmitry Gutov
2015-06-04 15:34 ` Eli Zaretskii
2015-06-04 15:36 ` Dmitry Gutov
2015-06-04 15:39 ` Eli Zaretskii
2015-06-04 16:55 ` Dmitry Gutov
2015-06-04 17:16 ` Eli Zaretskii
2015-06-04 17:46 ` Dmitry Gutov
2015-06-04 19:23 ` Eli Zaretskii
2015-06-04 20:20 ` Dmitry Gutov
2015-06-05 6:58 ` Eli Zaretskii
2015-06-05 8:29 ` Dmitry Gutov
2015-06-05 8:59 ` Eli Zaretskii
2015-06-05 9:07 ` Dmitry Gutov
2015-06-05 9:23 ` Eli Zaretskii
2015-06-05 9:47 ` Dmitry Gutov
2015-06-05 22:17 ` Juri Linkov
2015-06-06 10:19 ` Dmitry Gutov
2015-06-06 22:04 ` Juri Linkov
2015-06-07 22:22 ` Dmitry Gutov
2015-06-09 23:32 ` Juri Linkov
2015-06-10 17:55 ` Dmitry Gutov
2015-06-10 23:49 ` Juri Linkov
2015-06-11 7:23 ` Dmitry Gutov
2015-06-11 23:20 ` Juri Linkov
2015-06-22 0:49 ` Dmitry Gutov
2015-06-22 22:33 ` Juri Linkov
2015-06-23 0:33 ` Dmitry Gutov
2015-06-27 21:11 ` Dmitry Gutov
2015-06-27 22:49 ` Juri Linkov
2015-06-28 1:22 ` Dmitry Gutov
2015-06-28 1:39 ` Dmitry Gutov
2015-06-28 2:42 ` Eli Zaretskii
2015-06-28 8:05 ` Dmitry Gutov
2015-06-28 14:35 ` Eli Zaretskii
2015-06-28 19:02 ` Dmitry Gutov
2015-06-28 20:28 ` Eli Zaretskii
2015-06-28 20:31 ` Dmitry Gutov
2015-06-29 2:36 ` Eli Zaretskii
2015-06-29 10:08 ` Dmitry Gutov
2015-06-29 14:49 ` Eli Zaretskii
2015-06-29 15:01 ` Dmitry Gutov
2015-06-29 15:26 ` Eli Zaretskii
2015-06-29 16:11 ` Dmitry Gutov [this message]
2015-06-29 16:24 ` Eli Zaretskii
2015-06-29 16:26 ` Dmitry Gutov
2015-07-11 13:58 ` Eli Zaretskii
2015-07-11 15:57 ` Dmitry Gutov
2015-06-29 10:05 ` Dmitry Gutov
2015-06-29 14:44 ` Eli Zaretskii
2015-06-29 14:50 ` Dmitry Gutov
2015-06-29 15:15 ` Eli Zaretskii
2015-06-04 22:50 ` Juri Linkov
2015-06-05 9:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55916E27.3010200@yandex.ru \
--to=dgutov@yandex.ru \
--cc=20728@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.