all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master c4151eb: Improve the optional translation of quotes
Date: Thu, 25 Jun 2015 15:52:35 +0300	[thread overview]
Message-ID: <558BF993.2010105@yandex.ru> (raw)
In-Reply-To: <558A3F12.3080005@cs.ucla.edu>

On 06/24/2015 08:24 AM, Paul Eggert wrote:

> As I mentioned earlier I never fully understood the font-lock proposal.
> I could not easily decipher most of the abovementioned message.

Asking questions might help. I can't help but feel frustrated that you 
haven't made an informed decision. See the bottom of this email for the 
patch against f743819 (which was the version in master at the time). It 
only adds one line, the one I've mentioned in that message.

I'm not sure what more to explain, but the undesirable effect you've 
seen was due to 
http://www.gnu.org/software/emacs/manual/html_node/elisp/Syntactic-Font-Lock.html

> Luckily, though, the abovementioned message briefly mentioned not using
> font-locking and said of it "...but indeed, this approach could be the
> simpler one." -- an assessmeent that seemed sound to me -- and so I took
> the simpler approach.

I did say that, tentatively, and I've changed my mind since.

- Using font-lock will allow to change the output significantly in the 
future, without breaking the substitute-command-keys API.

- This functionality is closely related to linkification of identifiers 
between the quotes, also performed in Lisp (see the usages of 
help-xref-symbol-regexp). If substitute-command-keys handles escapes, 
help-xref-symbol-regexp (and the function using it) don't know whether a 
given quote was escaped or not). Especially if the source file can 
contain curly quotes, and substitute-command-keys also translates into them.

- "too tempting to implement complicated heuristics that would have been 
a pain to document" is not a good argument not to do something in a 
high-level language.

Now, there are still problems with that patch:

- It doesn't handle escaping either. Someone just needs to pick the 
escaping syntax, and we can handle it in Lisp just as well as in C. Why 
did we decide that "\\" isn't good enough?

- Like you said: "describe-variable should curve the quotes in the doc 
string, but not in the contents of the variable". The code that prints 
the value will need to add some text property to it ("verbatim"? 
"font-lock-ignore"?), and the font-lock rule can look it up and skip 
those regions. Nothing too hard.




  reply	other threads:[~2015-06-25 12:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150619073901.5856.32718@vcs.savannah.gnu.org>
     [not found] ` <E1Z5qtC-0001Xe-1y@vcs.savannah.gnu.org>
2015-06-21 19:09   ` [Emacs-diffs] master c4151eb: Improve the optional translation of quotes Dmitry Gutov
2015-06-21 19:56     ` Paul Eggert
2015-06-21 19:57       ` Dmitry Gutov
2015-06-21 20:03         ` Paul Eggert
2015-06-21 20:29           ` Dmitry Gutov
2015-06-21 20:46             ` Paul Eggert
2015-06-21 23:52               ` Dmitry Gutov
2015-06-22  6:50                 ` Paul Eggert
2015-06-22 15:09                   ` Dmitry Gutov
2015-06-23  5:36                     ` Paul Eggert
2015-06-23 10:55                       ` Dmitry Gutov
2015-06-24  5:24                         ` Paul Eggert
2015-06-25 12:52                           ` Dmitry Gutov [this message]
2015-06-25 14:05                             ` Paul Eggert
2015-06-25 14:56                               ` Dmitry Gutov
2015-07-31 18:51                                 ` Paul Eggert
2015-07-31 19:24                                   ` Dmitry Gutov
2015-08-01  1:16                                     ` Paul Eggert
2015-08-01  1:28                                       ` Dmitry Gutov
2015-06-25 14:59                               ` Dmitry Gutov
2015-06-25 15:11                                 ` Eli Zaretskii
2015-06-25 15:33                                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558BF993.2010105@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.