From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sva-news@mygooglest.com, 20843@debbugs.gnu.org
Subject: bug#20843: 24.5; Profiler error: "Invalid sampling interval"
Date: Mon, 22 Jun 2015 15:30:40 -0400 [thread overview]
Message-ID: <55886260.3040001@cornell.edu> (raw)
In-Reply-To: <83ioafh915.fsf@gnu.org>
On 6/22/2015 2:50 PM, Eli Zaretskii wrote:
>> Date: Mon, 22 Jun 2015 14:04:50 -0400
>> From: Ken Brown <kbrown@cornell.edu>
>> CC: sva-news@mygooglest.com, 20843@debbugs.gnu.org
>>
>>> Looks fine, but perhaps it would be cleaner to return the actual
>>> message string or some distinctive code from setup_cpu_timer. This
>>> would avoid the need for a global variable.
>>
>> Is this better?
>
> Yes, thanks.
Pushed as commit dc30fb92. I'm not closing the bug yet, because I still want to
follow up on your suggestion about reusing the w32 code.
Ken
prev parent reply other threads:[~2015-06-22 19:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 8:37 bug#20843: 24.5; Profiler error: "Invalid sampling interval" Sebastien Vauban
2015-06-18 8:57 ` Eli Zaretskii
[not found] ` <83k2v1l7g4.fsf-mXXj517/zsQ@public.gmane.org>
2015-06-18 11:58 ` Sebastien Vauban
[not found] ` <mailman.5225.1434628753.904.bug-gnu-emacs@gnu.org>
[not found] ` <mailman.5225.1434628753.904.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2015-06-19 13:38 ` Sebastien Vauban
2015-06-19 17:42 ` Eli Zaretskii
2015-06-20 19:02 ` Ken Brown
2015-06-20 19:10 ` Eli Zaretskii
2015-06-20 21:47 ` Ken Brown
2015-06-21 14:56 ` Eli Zaretskii
2015-06-21 22:17 ` Ken Brown
[not found] ` <558737F7.4080709-HmMyXyqgL2CVc3sceRu5cw@public.gmane.org>
2015-06-22 8:00 ` Sebastien Vauban
2015-06-22 11:57 ` Ken Brown
2015-06-22 15:12 ` Eli Zaretskii
2015-06-22 21:15 ` Ken Brown
2015-06-22 21:44 ` Ken Brown
[not found] ` <558881B0.6080404-HmMyXyqgL2CVc3sceRu5cw@public.gmane.org>
2015-06-23 8:39 ` Sebastien Vauban
2015-06-23 17:20 ` Ken Brown
[not found] ` <mailman.5513.1435080075.904.bug-gnu-emacs@gnu.org>
[not found] ` <mailman.5513.1435080075.904.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2015-07-02 13:27 ` Sebastien Vauban
2015-07-02 13:59 ` Ken Brown
2015-06-22 15:35 ` Eli Zaretskii
2015-06-22 18:04 ` Ken Brown
2015-06-22 18:50 ` Eli Zaretskii
2015-06-22 19:30 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55886260.3040001@cornell.edu \
--to=kbrown@cornell.edu \
--cc=20843@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sva-news@mygooglest.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.