From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master c4151eb: Improve the optional translation of quotes Date: Sun, 21 Jun 2015 23:50:17 -0700 Organization: UCLA Computer Science Department Message-ID: <5587B029.5000503@cs.ucla.edu> References: <20150619073901.5856.32718@vcs.savannah.gnu.org> <55870BD2.6040706@yandex.ru> <558716E9.30903@cs.ucla.edu> <55871721.5060709@yandex.ru> <55871883.7080600@cs.ucla.edu> <55871E96.2020506@yandex.ru> <558722C0.5040702@cs.ucla.edu> <55874E55.4020501@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1434955858 9369 80.91.229.3 (22 Jun 2015 06:50:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Jun 2015 06:50:58 +0000 (UTC) To: Dmitry Gutov , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 22 08:50:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z6vZA-00015h-FW for ged-emacs-devel@m.gmane.org; Mon, 22 Jun 2015 08:50:48 +0200 Original-Received: from localhost ([::1]:38382 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6vZ9-0004Te-HY for ged-emacs-devel@m.gmane.org; Mon, 22 Jun 2015 02:50:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6vYs-0004TJ-Ve for emacs-devel@gnu.org; Mon, 22 Jun 2015 02:50:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6vYn-00009t-Sa for emacs-devel@gnu.org; Mon, 22 Jun 2015 02:50:30 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6vYn-000096-M2 for emacs-devel@gnu.org; Mon, 22 Jun 2015 02:50:25 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 25075160836; Sun, 21 Jun 2015 23:50:23 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BV-Z58eC2Aqm; Sun, 21 Jun 2015 23:50:22 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 31AEF160837; Sun, 21 Jun 2015 23:50:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VHAxBlcwasES; Sun, 21 Jun 2015 23:50:22 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 12F3D160821; Sun, 21 Jun 2015 23:50:22 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: <55874E55.4020501@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187366 Archived-At: Dmitry Gutov wrote: >> substitute-command-keys has never been idempotent. > > Shouldn't we try not to make things worse? I don't see the point. Code should never invoke substitute-command-keys on the output of substitute-command-keys; the function is not designed that way. That's always been true. It's not "making things worse" to rely on a property that's been in Emacs for ages. >> If I understand you correctly, curved quotes will normally be kept in >> destination strings so it should be OK. > > They would make little no to sense in the source strings. Have you read this > subthread? > > http://lists.gnu.org/archive/html/emacs-devel/2015-06/msg00358.html Yes, I've been reading and participating in these subthreads. I don't follow your point here, though. Normally, curved quotes pass through substitute-command-keys unchanged. This is simple and intuitive and is what Emacs has always normally done. Perhaps we'll come up with a better way to highlight the output of substitute-command-keys at some point, a way that treats quotes and key substitutions differently. That might be nice, but it's not clear how it would work exactly, and in the meantime we have a simple approach that does work.