From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 20847@debbugs.gnu.org
Subject: bug#20847: [display engine] 25.0.50; company-mode popup makes point jump to an entirely different location
Date: Sun, 21 Jun 2015 23:01:10 +0300 [thread overview]
Message-ID: <55871806.1070903@yandex.ru> (raw)
In-Reply-To: <83egl5hr0t.fsf@gnu.org>
On 06/21/2015 09:09 PM, Eli Zaretskii wrote:
> No, I expect the cursor to be drawn on the fringe, like the user
> expects. (Or maybe I misunderstand what you meant by "earlier".) You
> should give the 'cursor' property an integer value, so that it
> "covers" the buffer position of the newline.
Ok, thanks. I forgot that `cursor' can have an integer value.
> There are only 2 situations, from your POV: either a line goes all the
> way to the window edge, or it doesn't.
Could you suggest the best way to check whether the former is the case?
(>= (car (posn-col-row (posn-at-point)))
(window-width))
> The former can happen either if there's a newline that ends a line,
> or if word-wrap is in effect.
Does that constitute at least three different cases we'd need to handle?
- Not near the window edge
- near the edge and newline
- near the edge and no newline?
> Yes, there could be such artifacts, but IMO losing some of the text is
> worse.
I'm not sure what you mean by "losing some of the text".
> And the problems you describe will be only on the lines
> actually used for the popup; the rest of the lines, which just copy
> buffer text into an overlay string, will look exactly like they did
> before, including the continuation markers.
Err, why this distinction?
If anything, I guess we could "replace" only the first newline inside
the overlay display string with wrapping, while keeping the rest as
newlines, because they are irrelevant to this bug.
>> Start the popup overlay at the end of the preceding line, and include a
>> newline in its display string (because there's no newline in the
>> buffer).
>
> I had no problems with that newline.
Sure. In those circumstances, moving point to the end of the overlay
would be a no-op anyway.
next prev parent reply other threads:[~2015-06-21 20:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 1:04 bug#20847: [display engine] 25.0.50; company-mode popup makes point jump to an entirely different location Dmitry Gutov
2015-06-19 19:07 ` Eli Zaretskii
2015-06-20 11:51 ` Eli Zaretskii
2015-06-21 13:56 ` Dmitry Gutov
2015-06-21 16:43 ` Eli Zaretskii
2015-06-21 18:06 ` Dmitry Gutov
2015-06-21 18:24 ` Eli Zaretskii
2015-06-21 19:23 ` Eli Zaretskii
2015-06-21 20:17 ` Dmitry Gutov
2015-06-21 20:02 ` Dmitry Gutov
2015-06-22 2:45 ` Eli Zaretskii
2015-06-22 11:01 ` Dmitry Gutov
2015-06-22 13:40 ` Dmitry Gutov
2015-06-22 16:26 ` Eli Zaretskii
2015-06-22 21:06 ` Dmitry Gutov
2015-06-23 16:39 ` Eli Zaretskii
2015-06-23 18:44 ` Dmitry Gutov
2015-06-23 19:07 ` Eli Zaretskii
2015-06-23 21:15 ` Dmitry Gutov
2015-06-24 16:18 ` Eli Zaretskii
2015-06-29 15:48 ` Dmitry Gutov
2015-06-30 17:46 ` Eli Zaretskii
2015-06-30 19:41 ` Dmitry Gutov
2015-06-30 20:11 ` Eli Zaretskii
2015-06-30 20:20 ` Dmitry Gutov
2015-07-01 2:42 ` Eli Zaretskii
2015-07-01 10:21 ` Dmitry Gutov
2015-07-01 15:16 ` Eli Zaretskii
2015-07-01 16:36 ` Dmitry Gutov
2015-07-01 16:40 ` Eli Zaretskii
2015-06-21 13:30 ` Dmitry Gutov
2015-06-21 14:16 ` Dmitry Gutov
2015-06-21 16:24 ` Eli Zaretskii
2015-06-21 17:46 ` Dmitry Gutov
2015-06-21 18:09 ` Eli Zaretskii
2015-06-21 20:01 ` Dmitry Gutov [this message]
2015-06-22 2:43 ` Eli Zaretskii
2015-06-22 10:57 ` Dmitry Gutov
2015-06-22 16:23 ` Eli Zaretskii
2015-06-23 0:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55871806.1070903@yandex.ru \
--to=dgutov@yandex.ru \
--cc=20847@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.