bug#20857: 25.0.50; Display of curved quotes in *Help* buffers on text terminals

bug#20857: 25.0.50; Display of curved quotes in *Help* buffers on text terminals

[Eli Zaretskii]

To reproduce:

 Set up your text terminal for some encoding that doesn't support
 curved quotes.  In my case, this was cp862.  Then:

 emacs -Q
 C-h f electric-quote-mode RET
 C-x o

You are now in the *Help* buffer.  Move point to the ‘ character in
the line that says

  When enabled, this replaces `foo bar' with ‘foo bar’ and replaces

(on the terminal set up as above, you should see 'foo bar' instead of
‘foo bar’, with straight ASCII single quotes), and type "C-u C-x =".
I expect to see that this is a U+2018 character displayed as ' via a
display table, but instead I see that the character is U+0027, the
ASCII quote itself.

This doesn't happen with the double quotes, U+201C and U+201D.  With
them, I do see the expected description.

Are my expectations wrong?

On a GUI terminal that is capable of displaying the curved quotes,
they display correctly as ‘..’.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
d:/gnu/git/emacs/trunk/etc/DEBUG.


In GNU Emacs 25.0.50.188 (i686-pc-mingw32)
 of 2015-06-20 on HOME-C4E4A596F7
Repository revision: 133848247344af93a710d050f064019a40fde801
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --prefix=/d/usr --enable-checking=yes,glyphs --with-wide-int
 'CFLAGS=-gdwarf-4 -g3 -O0''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window.

Char: ' (39, #o47, #x27) point=378 of 729 (52%) column=43
Mark set


Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message dired format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils wid-edit cl-loaddefs pcase cl-lib
descr-text help-mode easymenu help-fns time-date mule-util tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32
ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote w32notify w32 multi-tty
make-network-process emacs)

Memory information:
((conses 16 83206 7724)
 (symbols 56 29257 0)
 (miscs 48 38 149)
 (strings 16 24222 4758)
 (string-bytes 1 595680)
 (vectors 16 9099)
 (vector-slots 8 378482 19316)
 (floats 8 122 270)
 (intervals 40 256 163)
 (buffers 856 12))

bug#20857: 25.0.50; Display of curved quotes in *Help* buffers on text terminals

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Thanks, that bug was fallout from the recent introduction of 
‘help-quote-translation’.  I fixed it by installing the attached patch.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-quoting-in-electric-quote-mode-doc-string.patch --]
[-- Type: text/x-diff; name="0001-Fix-quoting-in-electric-quote-mode-doc-string.patch", Size: 1217 bytes --]

From a2f9d2ab2a8168a6e5a1cf9a5219ccd7ff847e35 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 20 Jun 2015 13:33:33 -0700
Subject: [PATCH 1/2] Fix quoting in electric-quote-mode doc string
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lisp/electric.el (electric-quote-mode): Fix quoting.
This is a fallout from the recent change introducing
‘help-quote-translation’.
---
 lisp/electric.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/electric.el b/lisp/electric.el
index 88b2835..ca05c8c 100644
--- a/lisp/electric.el
+++ b/lisp/electric.el
@@ -486,7 +486,7 @@ With a prefix argument ARG, enable Electric Quote mode if
 ARG is positive, and disable it otherwise.  If called from Lisp,
 enable the mode if ARG is omitted or nil.
 
-When enabled, this replaces \\=`foo bar' with ‘foo bar’ and replaces
+When enabled, this replaces \\=`foo bar' with \\=‘foo bar\\=’ and replaces
 \\=`\\=`foo bar'' with “foo bar” as you type.  This occurs only in
 comments, strings, and text paragraphs, and these are selectively
 controlled with ‘electric-quote-comment’,
-- 
2.1.4

bug#20857: 25.0.50; Display of curved quotes in *Help* buffers on text terminals

[Eli Zaretskii]

> Date: Sat, 20 Jun 2015 13:40:12 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
> 
> Thanks, that bug was fallout from the recent introduction of 
> ‘help-quote-translation’.  I fixed it by installing the attached patch.

Thanks, works for me.