From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#20754: checkdoc-current-buffer prints to stdout?! Date: Sat, 06 Jun 2015 11:50:57 -0700 Organization: UCLA Computer Science Department Message-ID: <55734111.60208@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1433616752 6121 80.91.229.3 (6 Jun 2015 18:52:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Jun 2015 18:52:32 +0000 (UTC) Cc: Sebastian Wiesner , Oleh Krehel To: 20754@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 06 20:52:20 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z1JCV-0000UT-Mo for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jun 2015 20:52:11 +0200 Original-Received: from localhost ([::1]:52333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JCU-0002i3-Op for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jun 2015 14:52:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JCR-0002hr-Be for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1JCM-0002sb-Aq for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:52:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JCM-0002sV-7h for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z1JCM-0006BU-0K for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2015 18:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Emacs bug reports and feature requests Original-Received: via spool by submit@debbugs.gnu.org id=B.143361667423716 (code B ref -1); Sat, 06 Jun 2015 18:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jun 2015 18:51:14 +0000 Original-Received: from localhost ([127.0.0.1]:43480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1JBa-0006AR-2B for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:51:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57622) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1JBY-0006AF-5r for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:51:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1JBR-0002Fm-Um for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:51:07 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:60391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JBR-0002Fg-RZ for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:51:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JBQ-0002dx-Pv for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1JBL-0002Dj-Pa for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:51:04 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1JBL-0002DY-Eg for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2015 14:50:59 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BADDD1606CF; Sat, 6 Jun 2015 11:50:58 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Y4Ym7G_5LG5E; Sat, 6 Jun 2015 11:50:57 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C4BE21606DB; Sat, 6 Jun 2015 11:50:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jAfuFSsaq9KN; Sat, 6 Jun 2015 11:50:57 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9F3F01606CF; Sat, 6 Jun 2015 11:50:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103670 Archived-At: [The following bug report was sent by Sebastian Wiesner to emacs-devel=20 .] Hello, while debugging unit test failures in Flycheck, I accidentally discovered checkdoc-current-buffer apparently prints messages to standard output in Emacs 25.1 in noninteractive mode. Would you please revert this change? I can understand the motivation for this =E2=80=9Cfeature=E2=80=9D, but i= t's generally a bad idea for an interactive function to print text to standard output depending on an opaque global environment. It also makes backwards compatibility harder than it needs to be: As things stand I have no choi= ce but to check the Emacs version to print Checkdoc Errors in a consistent w= ay across Emacs major versions, and that is somewhat ugly. The purpose of this feature would also be served by a different entry point=E2=80=94we have `ert-run-tests-interactively` and `ert-run-tests-ba= tch`, too. If that is impossible please at least expose an option to turn this feature off. On a related topic, I'd have fixed this issue much faster, had this chang= e been mentioned in the NEWS. Would you please be more strict about updati= ng NEWS for breaking changes such as this? Sincerely, Sebastian Wiesner