all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: 20754@debbugs.gnu.org
Cc: Sebastian Wiesner <swiesner@lunaryorn.com>,
	Oleh Krehel <ohwoeowho@gmail.com>
Subject: bug#20754: checkdoc-current-buffer prints to stdout?!
Date: Sat, 06 Jun 2015 11:50:57 -0700	[thread overview]
Message-ID: <55734111.60208@cs.ucla.edu> (raw)

[The following bug report was sent by Sebastian Wiesner to emacs-devel 
<http://lists.gnu.org/archive/html/emacs-devel/2015-06/msg00095.html>.]

Hello,

while debugging unit test failures in Flycheck, I accidentally discovered
checkdoc-current-buffer apparently prints messages to standard output in
Emacs 25.1 in noninteractive mode.

Would you please revert this change?

I can understand the motivation for this “feature”, but it's generally a
bad idea for an interactive function to print text to standard output
depending on an opaque global environment.  It also makes backwards
compatibility harder than it needs to be:  As things stand I have no choice
but to check the Emacs version to print Checkdoc Errors in a consistent way
across Emacs major versions, and that is somewhat ugly.

The purpose of this feature would also be served by a different entry
point—we have `ert-run-tests-interactively` and `ert-run-tests-batch`,
too.  If that is impossible please at least expose an option to turn this
feature off.

On a related topic, I'd have fixed this issue much faster, had this change
been mentioned in the NEWS.  Would you please be more strict about updating
NEWS for breaking changes such as this?

Sincerely,
Sebastian Wiesner





             reply	other threads:[~2015-06-06 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-06 18:50 Paul Eggert [this message]
2015-06-07 14:23 ` bug#20754: checkdoc-current-buffer prints to stdout?! Oleh Krehel
2015-06-07 15:29   ` Sebastian Wiesner
2015-06-08  6:35     ` Oleh Krehel
2015-06-08  9:17       ` Sebastian Wiesner
2015-06-08  9:33         ` Oleh Krehel
2015-06-07 18:27   ` Glenn Morris
2015-06-08  5:56     ` Oleh Krehel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55734111.60208@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=20754@debbugs.gnu.org \
    --cc=ohwoeowho@gmail.com \
    --cc=swiesner@lunaryorn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.