From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 20728@debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Sat, 6 Jun 2015 13:19:34 +0300 [thread overview]
Message-ID: <5572C936.6070505@yandex.ru> (raw)
In-Reply-To: <87a8wdhka7.fsf@mail.linkov.net>
On 06/06/2015 01:17 AM, Juri Linkov wrote:
> There is also grep-find-command used by grep-find.
Indeed. That one I'd rather leave alone too.
> Since there is a lot of %s-substitutions in grep-compute-defaults
> that produce command lines depending on many customizations,
Not that many. grep-program and grep-highlight-matches seem to be the
only ones a user might want to change. Or rather, a user might change
the former, and some function might want to change either.
> yet another option is to let-bind the variables grep-command,
> grep-find-command, grep-template, grep-find-template in your function,
> then call grep-compute-defaults with a new value of grep-highlight-matches,
> and then get new command lines without the --color option from
> these local bindings to run them and parse the output programmatically.
That's what zrgrep does, and its quite clunky. And if we have code to
pre-compute commands and templates (which takes several external program
calls), it's kind of silly to redo that again each time certain commands
are called.
Do you know if zrgrep has a good reason for it? Like, it there are
platforms where we have to use different calling conventions for grep
and zgrep? Otherwise, we could simply substitute grep-program value in
the commands.
> In case when users customize grep-highlight-matches interactively,
> its defcustom should compute new command lines using grep-compute-defaults.
Do you think, overall, it will be the better approach?
next prev parent reply other threads:[~2015-06-06 10:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 23:42 bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Dmitry Gutov
2015-06-04 2:43 ` Eli Zaretskii
2015-06-04 8:58 ` Dmitry Gutov
2015-06-04 15:01 ` Eli Zaretskii
2015-06-04 15:18 ` Dmitry Gutov
2015-06-04 15:34 ` Eli Zaretskii
2015-06-04 15:36 ` Dmitry Gutov
2015-06-04 15:39 ` Eli Zaretskii
2015-06-04 16:55 ` Dmitry Gutov
2015-06-04 17:16 ` Eli Zaretskii
2015-06-04 17:46 ` Dmitry Gutov
2015-06-04 19:23 ` Eli Zaretskii
2015-06-04 20:20 ` Dmitry Gutov
2015-06-05 6:58 ` Eli Zaretskii
2015-06-05 8:29 ` Dmitry Gutov
2015-06-05 8:59 ` Eli Zaretskii
2015-06-05 9:07 ` Dmitry Gutov
2015-06-05 9:23 ` Eli Zaretskii
2015-06-05 9:47 ` Dmitry Gutov
2015-06-05 22:17 ` Juri Linkov
2015-06-06 10:19 ` Dmitry Gutov [this message]
2015-06-06 22:04 ` Juri Linkov
2015-06-07 22:22 ` Dmitry Gutov
2015-06-09 23:32 ` Juri Linkov
2015-06-10 17:55 ` Dmitry Gutov
2015-06-10 23:49 ` Juri Linkov
2015-06-11 7:23 ` Dmitry Gutov
2015-06-11 23:20 ` Juri Linkov
2015-06-22 0:49 ` Dmitry Gutov
2015-06-22 22:33 ` Juri Linkov
2015-06-23 0:33 ` Dmitry Gutov
2015-06-27 21:11 ` Dmitry Gutov
2015-06-27 22:49 ` Juri Linkov
2015-06-28 1:22 ` Dmitry Gutov
2015-06-28 1:39 ` Dmitry Gutov
2015-06-28 2:42 ` Eli Zaretskii
2015-06-28 8:05 ` Dmitry Gutov
2015-06-28 14:35 ` Eli Zaretskii
2015-06-28 19:02 ` Dmitry Gutov
2015-06-28 20:28 ` Eli Zaretskii
2015-06-28 20:31 ` Dmitry Gutov
2015-06-29 2:36 ` Eli Zaretskii
2015-06-29 10:08 ` Dmitry Gutov
2015-06-29 14:49 ` Eli Zaretskii
2015-06-29 15:01 ` Dmitry Gutov
2015-06-29 15:26 ` Eli Zaretskii
2015-06-29 16:11 ` Dmitry Gutov
2015-06-29 16:24 ` Eli Zaretskii
2015-06-29 16:26 ` Dmitry Gutov
2015-07-11 13:58 ` Eli Zaretskii
2015-07-11 15:57 ` Dmitry Gutov
2015-06-29 10:05 ` Dmitry Gutov
2015-06-29 14:44 ` Eli Zaretskii
2015-06-29 14:50 ` Dmitry Gutov
2015-06-29 15:15 ` Eli Zaretskii
2015-06-04 22:50 ` Juri Linkov
2015-06-05 9:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5572C936.6070505@yandex.ru \
--to=dgutov@yandex.ru \
--cc=20728@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.