From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Da Zhang Newsgroups: gmane.emacs.bugs Subject: bug#20744: shell-quote-argument in Emacs 24.5 and Emacs 25 on Windows cannot figure out path correctly Date: Fri, 05 Jun 2015 16:50:46 -0400 Message-ID: <55720BA6.60809@gmail.com> References: <5571CF77.5000902@gmail.com> <83oaktoqw1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1433537548 9402 80.91.229.3 (5 Jun 2015 20:52:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jun 2015 20:52:28 +0000 (UTC) Cc: 20744@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 05 22:52:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z0yb6-00089B-CV for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 22:52:12 +0200 Original-Received: from localhost ([::1]:49534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yb5-0005jF-Eo for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jun 2015 16:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yb2-0005jA-3a for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:52:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0yax-0003iT-2t for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:52:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yaw-0003iL-SU for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z0yaw-0006yM-Iv for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Da Zhang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.143353747026745 (code B ref -1); Fri, 05 Jun 2015 20:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jun 2015 20:51:10 +0000 Original-Received: from localhost ([127.0.0.1]:42232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ya5-0006xI-CJ for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:51:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53023) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ya2-0006wl-1y for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0yZv-0003Bn-DI for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:51:00 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:38614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yZv-0003Bd-9r for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:50:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yZt-0005fb-Rx for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:50:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0yZo-00039z-A4 for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 16:50:57 -0400 Original-Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]:35260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0yZo-00039u-2e; Fri, 05 Jun 2015 16:50:52 -0400 Original-Received: by qkhq76 with SMTP id q76so46668458qkh.2; Fri, 05 Jun 2015 13:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=vblxsv+PQibVLY7myxGwcGvzwQRbeDkBG4rN/r4vhBY=; b=uDRonL+C8Uxq/yL92DvzGNB1W3rBlefU1ebUvNgMVmiy4N3c1u9bt016WybwuxU0w2 gnUuDUfda78Kj+VQEjcMlA6Hwz179s0Vzzv13tElxLfobxwJfKlQ8Y2QU0h3ZCZnQ8fT c+JmEZOR+yn4CmZp34aoc8nyMnacLiKEf9OGwA66CUg/cqMYsxkZZvC/mEu8ZWhgzukn vnImRH/KvtutOPSYX7FGgLsEpWtLR+gyQ7gGe2MYi6xUpLVvOvBT4WrlAT6nos+d9Ne9 Y5gukj5nH461Yt04cHlTq64EOidGUNQjuFOawHQ5quSIk7nnSSaGQlerLBLaV4wkjqHh 5g+A== X-Received: by 10.141.18.202 with SMTP id u193mr6527306qhd.16.1433537451666; Fri, 05 Jun 2015 13:50:51 -0700 (PDT) Original-Received: from [10.35.157.65] ([134.174.110.14]) by mx.google.com with ESMTPSA id k133sm4459261qhc.35.2015.06.05.13.50.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 13:50:51 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: <83oaktoqw1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103633 Archived-At: Hello Eli,

Thanks for looking into this again. The change I made is a very ugly hack, and I did not use it actually -- instead, I just changed the python.el to avoid using shell-quote-argument.
For work reason I have to use Windows, but I do use cygwin bash as my working shell and it's convenient to have emacs and bash together, such as in dired, grep, etc.
I understand using cmd.exe could solve the problem, but I am reporting this issue in subr.el, particularly, shell-quote-argument, because I think the current code is forcing Windows users to use the cmd shell.

In fact, I did not see such a problem before Emacs 24.3. There might be some changes since then. In addition, there is a 10-years old post in
http://lists.gnu.org/archive/html/emacs-devel/2005-03/msg00313.html
talking about the similar problem, and the lister mentioned
" 
It seems very usual for emacs users on w32 to use cygwin or mingw.
Right now shell-quote-argument would return something wrong when bash
or some "intelligent" shell is used on w32 because it assumes a dumb
w32 shell.
"

I am no expert in this this fundamental lisp model of subr.el, and the consequence of changing it. That's why I am reporting this as a bug in the hope some higher experts could lend some help.

Thanks.

Da Zhang

On 6/5/2015 4:13 PM, Eli Zaretskii wrote:
Date: Fri, 05 Jun 2015 12:33:59 -0400
From: Da Zhang <zhangda82@gmail.com>

I use python mode (python.el) for some python programming. When I invoke
the command python-shell-send-buffer, my Emacs always reports "Searching
for program: no such file or directory,
c\:/Anaconda3/Scripts/ipython.exe".

I traced down the cause of this problem, and found the following lines
in python.el:
(defun python-shell-parse-command () ;FIXME: why name it "parse"?
"Calculate the string used to execute the inferior Python process."
;; FIXME: process-environment doesn't seem to be used anywhere within
;; this let.
(let ((process-environment (python-shell-calculate-process-environment))
(exec-path (python-shell-calculate-exec-path)))
(format "%s %s"
;; FIXME: Why executable-find?
(shell-quote-argument (executable-find python-shell-interpreter))
python-shell-interpreter-args)))

The function call 
(shell-quote-argument (executable-find python-shell-interpreter))
changed the path of my python interpreter from
"c:/Anaconda3/Scripts/ipython.exe"
to
"c\\:/Anaconda3/Scripts/ipython.exe".

I worked around this problem by replacing the function call
(shell-quote-argument (executable-find python-shell-interpreter))
with
(executable-find python-shell-interpreter) ;; edited by DZ on
2015/06/05: (shell-quote-argument) caused the problem of
"c\\:/Anaconda3/Scripts/ipython.exe"

To further analyze the problem, I found the function
shell-quote-argument defined in subr.el does not deal with the case when
bash from cygwin is used.

For the record, this is bug #20237.


I added the following lines in the cond statement, to solve the problem.
((and (eq system-type 'windows-nt) (if (string-match ".*cygwin.*"
(w32-shell-name)) t nil)) ;; DZ's edit on 6/5/2015
(if (equal argument "")
"''"
;; Quote everything except POSIX filename characters.
;; This should be safe enough even for really weird shells.
(replace-regexp-in-string
"\n" "'\n'"
(replace-regexp-in-string "[^-0-9a-zA-Z_./\n:]" "\\\\\\&" argument))))

I'm sorry, but I don't see how we can accept such a change: it means
that when the Cygwin Bash is used as the shell, the ':' character will
not be quoted, which I think could cause trouble in some cases.

Maybe some Bash expert could chime in and tell whether problems are
possible with Bash in this case.

Is there any way you could avoid using the Cygwin Bash as the shell
when running the native Windows build of Emacs?  That would make the
problem go away without any need for changes.