bug#20719: 25.0.50; grep-find-template has no <D> placeholder

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Dmitry Gutov]

Which goes counter to its docstring.

Instead, it just starts with 'find . ', and grep-expand-template, when
used with it, always ignores its DIR argument.

Why don't we replace all occurrences of ' . ' in grep-compute-defaults
with ' <D> '?

In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2)
 of 2015-06-02 on axl
Windowing system distributor `The X.Org Foundation', version 11.0.11601901
System Description:	Ubuntu 14.10

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Dmitry Gutov]

Originally, it was present in the computed value of grep-tree-template.

But in the same commit that renamed it to grep-find-template 
(2006-04-28, 0acfb7ce), "<D>" was replaced with ".".

Kim, do you remember why? The commit message doesn't seem to provide an 
adequate explanation.

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Kim Storm]

On 2015-06-02 16:28, Dmitry Gutov wrote:
> Originally, it was present in the computed value of grep-tree-template.
>
> But in the same commit that renamed it to grep-find-template 
> (2006-04-28, 0acfb7ce), "<D>" was replaced with ".".
>
> Kim, do you remember why? The commit message doesn't seem to provide 
> an adequate explanation.
>

I suppose it was because "rgrep" changes the default directory to the 
specified "dir" before
running the find command - so "." seems to be TRT (and makes the command 
shorter):

       (let ((default-directory dir))
         (compilation-start command 'grep-mode))

Kim

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Dmitry Gutov]

On 06/02/2015 07:11 PM, Kim Storm wrote:

> I suppose it was because "rgrep" changes the default directory to the
> specified "dir" before
> running the find command - so "." seems to be TRT (and makes the command
> shorter):

So there's no particular reason for that change?

`rgrep' can pass "." in just as well. However, `grep-find-template' can 
be used outside of `rgrep', and the current value contradicts its docstring.

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Kim Storm]

On 2015-06-02 20:34, Dmitry Gutov wrote:
> On 06/02/2015 07:11 PM, Kim Storm wrote:
>
>> I suppose it was because "rgrep" changes the default directory to the
>> specified "dir" before
>> running the find command - so "." seems to be TRT (and makes the command
>> shorter):
>
> So there's no particular reason for that change?
The reason is because it was TRT - but obviously not the best way to do 
it...
>
> `rgrep' can pass "." in just as well.
>
Yes, that seems like a better way.

But I think the <D> entry in grep-expand-keywords should be changed to:

     ("<D>" . (or dir "."))

as a <D> entry should always insert a directory even if passed a nil arg 
for DIR.

Kim

bug#20719: 25.0.50; grep-find-template has no <D> placeholder

[Dmitry Gutov]

Version: 25.1

On 06/03/2015 12:19 AM, Kim Storm wrote:

>> `rgrep' can pass "." in just as well.
>>
> Yes, that seems like a better way.

Done.

> But I think the <D> entry in grep-expand-keywords should be changed to:
>
>      ("<D>" . (or dir "."))
>
> as a <D> entry should always insert a directory even if passed a nil arg
> for DIR.

Sounds ok to me. Even though it makes the last argument to 
rgrep-default-command look superfluous.