From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Eli Zaretskii" <eliz@is.elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Show/Hide changes in menu-bar.el
Date: Fri, 10 May 2002 12:48:46 +0300
Sender: emacs-devel-admin@gnu.org
Message-ID: <5567-Fri10May2002124845+0300-eliz@is.elta.co.il>
Reply-To: Eli Zaretskii <eliz@is.elta.co.il>
NNTP-Posting-Host: localhost.gmane.org
X-Trace: main.gmane.org 1021024278 21994 127.0.0.1 (10 May 2002 09:51:18 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Fri, 10 May 2002 09:51:18 +0000 (UTC)
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 17673W-0005id-00
	for <emacs-devel@main.gmane.org>; Fri, 10 May 2002 11:51:18 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 1767CY-0005cE-00
	for <emacs-devel@quimby.gnus.org>; Fri, 10 May 2002 12:00:38 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 17673M-0004LG-00; Fri, 10 May 2002 05:51:08 -0400
Original-Received: from thor.inter.net.il ([192.114.186.11])
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 176723-0004Fr-00
	for <emacs-devel@gnu.org>; Fri, 10 May 2002 05:49:48 -0400
Original-Received: from Zaretsky ([80.230.2.40])
	by thor.inter.net.il (Mirapoint Messaging Server MOS 3.1.0.54-GA)
	with ESMTP id AFF31920;
	Fri, 10 May 2002 12:49:43 +0300 (IDT)
Original-To: emacs-devel@gnu.org
X-Mailer: emacs 21.2.50 (via feedmail 8 I) and Blat ver 1.8.9
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.9
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:3801
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3801

Recent changes in menu-bar.el used window-system to decide whether to
show certain display options in the menu.  Please avoid using
window-system as much as possible (not only fo the menu bar).  It is
the wrong tool to make such decisions.  In this particular case, it
actually did the wrong thing, since the MS-DOS port defines a non-nil
value for window-system, but doesn't support a tool bar and the scroll
bars.

It is best to condition on some symbol or function being bound: this
way, if/when the relevant feature gets implemented on the platforms
where it is currently unavailable, the menu bar will automatically
DTRT.  If you cannot find a symbol or a function, please use
display-*-p functions, as suggested by the ELisp manual.

Thanks.