Package refresh and install/delete marks

Package refresh and install/delete marks

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

> Async refreshing has grown on me too, but it still needs to implement
retaining the marks set by the user.

For the record, this is now done.
It was implemented by having tabulated-list only update the buffer, instead
of printing it anew.
As a bonus, the printing step is now blazing fast. So the small hang we get
after archives are downloaded is now barely noticeable.

Of note:
- if the user marks a package (for install/delete) and that package is gone
after the refresh, then the mark is gone too.
- if the user hits U while a refresh is in progress, the package menu will
wait until the refresh is done before actually marking the upgrades. This
is to avoid the scenario where the refresh could erase the install marks
and keep the delete marks.
- Hitting g will still revert the entire buffer and wipe all marks (this is
intentional).

[-- Attachment #2: Type: text/html, Size: 918 bytes --]

Re: Package refresh and install/delete marks

[Dmitry Gutov]

On 05/27/2015 04:49 AM, Artur Malabarba wrote:

> For the record, this is now done.
> It was implemented by having tabulated-list only update the buffer,
> instead of printing it anew.
> As a bonus, the printing step is now blazing fast. So the small hang we
> get after archives are downloaded is now barely noticeable.

Thank you, it's indeed pretty fast.

> - if the user hits U while a refresh is in progress, the package menu
> will wait until the refresh is done before actually marking the
> upgrades. This is to avoid the scenario where the refresh could erase
> the install marks and keep the delete marks.

That's not what I see here: U adds the marks if there's something to 
upgrade before the refresh, and when the latter completes, it removes them.

But speaking of this scenario, maybe this could be handled even better? 
Since you intend to defer adding marks to until after the refresh, why 
not defer calculation as well? In all likelihood, after the refresh is 
done, more packages will have upgrades.

Re: Package refresh and install/delete marks

[Artur Malabarba]

> That's not what I see here: U adds the marks if there's something to upgrade
> before the refresh, and when the latter completes, it removes them.

Ooops. I may have forgotten to push the commit. :-) Will push when I get home.

> But speaking of this scenario, maybe this could be handled even better?
> Since you intend to defer adding marks to until after the refresh, why not
> defer calculation as well? In all likelihood, after the refresh is done,
> more packages will have upgrades.

Yes, calculations are deferred as well. Basically, the entire command
is deferred. (This will be obvious when I actually push the commit
:-).

Re: Package refresh and install/delete marks

[Artur Malabarba]

2015-05-27 17:19 GMT+01:00 Artur Malabarba <bruce.connor.am@gmail.com>:
>> That's not what I see here: U adds the marks if there's something to upgrade
>> before the refresh, and when the latter completes, it removes them.
>
> Ooops. I may have forgotten to push the commit. :-) Will push when I get home.

Pushed.

Re: Package refresh and install/delete marks

[Dmitry Gutov]

On 05/27/2015 11:42 PM, Artur Malabarba wrote:

> Pushed.

Thanks. Looking good!