From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: etags test is broken on MS-Windows Date: Thu, 21 May 2015 09:37:02 -0700 Organization: UCLA Computer Science Department Message-ID: <555E09AE.9070208@cs.ucla.edu> References: <83y4kmdjmj.fsf@gnu.org> <555A8E62.7060700@cs.ucla.edu> <83h9r8egen.fsf@gnu.org> <83pp5t6gex.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1432226263 9761 80.91.229.3 (21 May 2015 16:37:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 May 2015 16:37:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , =?UTF-8?B?RnJhbmNlc2NvIFBvdG9ydMOs?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 21 18:37:34 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YvTTE-0002Um-4u for ged-emacs-devel@m.gmane.org; Thu, 21 May 2015 18:37:20 +0200 Original-Received: from localhost ([::1]:58604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvTTD-0007X2-Ei for ged-emacs-devel@m.gmane.org; Thu, 21 May 2015 12:37:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvTT9-0007UK-H8 for emacs-devel@gnu.org; Thu, 21 May 2015 12:37:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvTT5-0001nY-K4 for emacs-devel@gnu.org; Thu, 21 May 2015 12:37:15 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:56254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvTT1-0001dy-A4; Thu, 21 May 2015 12:37:07 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1D750A60010; Thu, 21 May 2015 09:37:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vXeoL8dczNOr; Thu, 21 May 2015 09:37:05 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6D0D2A60001; Thu, 21 May 2015 09:37:05 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: <83pp5t6gex.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186710 Archived-At: On 05/21/2015 09:31 AM, Eli Zaretskii wrote: > I think etags should use teh > same code in Unix as well. I mean this fragment: > > if (c == '\n') > { > if (p > buffer && p[-1] == '\r') > { > p -= 1; > #ifdef DOS_NT > /* Assume CRLF->LF translation will be performed by Emacs > when loading this file, so CRs won't appear in the buffer. > It would be cleaner to compensate within Emacs; > however, Emacs does not know how many CRs were deleted > before any given point in the file. */ > chars_deleted = 1; > #else > chars_deleted = 2; > #endif > } Sorry, I'm a little lost. Would it actually work with an Emacs on a GNUish host if we simply set chars_deleted = 1 here? If etags is locale-agnostic, its output files must contain byte counts and not character counts. This is because etags doesn't even know where the characters are. And if the output files contain byte counts, surely they need to count the CR bytes as well as the LF bytes, at least on a GNU or POSIXish host.