From: Paul Eggert <eggert@cs.ucla.edu>
To: "Eli Zaretskii" <eliz@gnu.org>, "Francesco Potortì" <pot@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: etags test is broken on MS-Windows
Date: Thu, 21 May 2015 09:37:02 -0700 [thread overview]
Message-ID: <555E09AE.9070208@cs.ucla.edu> (raw)
In-Reply-To: <83pp5t6gex.fsf@gnu.org>
On 05/21/2015 09:31 AM, Eli Zaretskii wrote:
> I think etags should use teh
> same code in Unix as well. I mean this fragment:
>
> if (c == '\n')
> {
> if (p > buffer && p[-1] == '\r')
> {
> p -= 1;
> #ifdef DOS_NT
> /* Assume CRLF->LF translation will be performed by Emacs
> when loading this file, so CRs won't appear in the buffer.
> It would be cleaner to compensate within Emacs;
> however, Emacs does not know how many CRs were deleted
> before any given point in the file. */
> chars_deleted = 1;
> #else
> chars_deleted = 2;
> #endif
> }
Sorry, I'm a little lost. Would it actually work with an Emacs on a
GNUish host if we simply set chars_deleted = 1 here?
If etags is locale-agnostic, its output files must contain byte counts
and not character counts. This is because etags doesn't even know where
the characters are. And if the output files contain byte counts, surely
they need to count the CR bytes as well as the LF bytes, at least on a
GNU or POSIXish host.
next prev parent reply other threads:[~2015-05-21 16:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83y4kmdjmj.fsf@gnu.org>
[not found] ` <555A8E62.7060700@cs.ucla.edu>
2015-05-19 15:27 ` etags test is broken on MS-Windows Eli Zaretskii
2015-05-19 17:57 ` Paul Eggert
2015-05-19 18:26 ` Eli Zaretskii
2015-05-20 15:38 ` Eli Zaretskii
2015-05-21 5:05 ` Paul Eggert
2015-05-21 13:24 ` Francesco Potortì
2015-05-21 16:49 ` Eli Zaretskii
2015-05-23 8:46 ` Eli Zaretskii
2015-05-21 13:16 ` Francesco Potortì
2015-05-21 16:31 ` Eli Zaretskii
2015-05-21 16:37 ` Paul Eggert [this message]
2015-05-21 16:55 ` Eli Zaretskii
2015-05-21 19:03 ` Paul Eggert
2015-05-21 19:54 ` Eli Zaretskii
2015-05-21 23:28 ` Paul Eggert
2015-05-22 8:32 ` Eli Zaretskii
2015-05-22 13:08 ` Francesco Potortì
2015-05-22 13:19 ` Eli Zaretskii
2015-05-22 18:23 ` Paul Eggert
2015-05-22 19:08 ` Eli Zaretskii
2015-05-22 19:25 ` Andreas Schwab
2015-05-22 19:38 ` Eli Zaretskii
2015-05-22 19:41 ` Andreas Schwab
2015-05-22 19:42 ` Eli Zaretskii
2015-05-22 19:50 ` Andreas Schwab
2015-05-22 20:05 ` Eli Zaretskii
2015-05-22 20:30 ` Andreas Schwab
2015-05-22 21:26 ` Paul Eggert
2015-05-23 6:40 ` Eli Zaretskii
2015-05-23 6:39 ` Eli Zaretskii
2015-05-23 8:02 ` Andreas Schwab
2015-05-23 8:27 ` Eli Zaretskii
2015-05-23 9:41 ` Andreas Schwab
2015-05-23 9:49 ` Eli Zaretskii
2015-05-23 9:59 ` Andreas Schwab
2015-05-23 10:20 ` Eli Zaretskii
2015-05-23 10:54 ` Andreas Schwab
2015-05-23 11:31 ` Eli Zaretskii
2015-05-23 12:10 ` Andreas Schwab
2015-05-23 13:46 ` Eli Zaretskii
2015-05-23 17:27 ` Andreas Schwab
2015-05-23 17:37 ` Eli Zaretskii
2015-05-23 18:46 ` Andreas Schwab
2015-05-23 19:04 ` Eli Zaretskii
2015-05-25 12:33 ` Francesco Potortì
2015-05-23 19:01 ` Paul Eggert
2015-05-23 19:27 ` Eli Zaretskii
2015-05-25 16:44 ` Paul Eggert
2015-05-25 19:33 ` Eli Zaretskii
2015-05-25 20:29 ` Paul Eggert
2015-05-22 12:40 ` Francesco Potortì
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E09AE.9070208@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pot@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.