From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: etags test is broken on MS-Windows Date: Tue, 19 May 2015 10:57:57 -0700 Organization: UCLA Computer Science Department Message-ID: <555B79A5.3020200@cs.ucla.edu> References: <83y4kmdjmj.fsf@gnu.org> <555A8E62.7060700@cs.ucla.edu> <83h9r8egen.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1432058317 7208 80.91.229.3 (19 May 2015 17:58:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2015 17:58:37 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 19 19:58:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YulmO-0001Wm-0v for ged-emacs-devel@m.gmane.org; Tue, 19 May 2015 19:58:12 +0200 Original-Received: from localhost ([::1]:47655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YulmM-0008Kl-4p for ged-emacs-devel@m.gmane.org; Tue, 19 May 2015 13:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YulmH-0008JN-Tb for emacs-devel@gnu.org; Tue, 19 May 2015 13:58:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YulmG-00060y-Py for emacs-devel@gnu.org; Tue, 19 May 2015 13:58:05 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:42376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YulmB-0005zz-F4; Tue, 19 May 2015 13:57:59 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E171BA6000A; Tue, 19 May 2015 10:57:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mi1asSr9ISMK; Tue, 19 May 2015 10:57:57 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6ACCFA60008; Tue, 19 May 2015 10:57:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: <83h9r8egen.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186624 Archived-At: On 05/19/2015 08:27 AM, Eli Zaretskii wrote: > I think it's due to DOS CR-LF EOL format of some files in the test suite. You're right, I misdiagnosed the porting problem. Sorry about that. > If we agree that the problem is due to EOL format, we could try > thinking about a solution. The root cause for the problem is that on > Windows, etags accounts for the stripped CR characters, while on Unix > it treats them as part of the contents, so the byte counts are offset > by the number of the preceding lines. That sounds like a problem, but not a problem that the test case is trying to detect. A simple way that should cajole the tests into passing is to remove the trailing CRs from the test data, so I installed a patch to do that. If we ever want to make ctags output portable among Unix vs DOS conventions we can bring back test cases involving CRs.