all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Ed Avis <eda@waniasset.com>,
	"19543@debbugs.gnu.org" <19543@debbugs.gnu.org>
Subject: bug#19543: 24.4; vc-mode: 'Fileset is up-to-date' even when vc-diff showed differences
Date: Sun, 17 May 2015 03:32:56 +0300	[thread overview]
Message-ID: <5557E1B8.3080609@yandex.ru> (raw)
In-Reply-To: <5A8CCC03-84BA-41C4-AD55-47A06F91B3DB@waniasset.com>

On 05/16/2015 07:19 PM, Ed Avis wrote:
> Another way to make it consistent would be for vc-diff to work based on what is currently in the buffer, not what's on disk.

We could, but being consistent with out-of-date information is not that 
valuable.

> But I think a better way to solve it would be for vc-next-action to include a quick check of the file's status on disk.  So before it confidently says "Fileset is up-to-date", it can go and test if the file has changed, and if so go into the usual Emacs prompts about whether to reload the buffer from disk.

I don't know; with TRAMP, for example, process calls are at a premium, 
and this would unconditionally increase their number, especially when 
committing many files.

Further, vc-dir already expects the state information to be up-to-date 
(it has some related checks and logic depending on it).

Aside from using auto-revert-mode, inferring the necessity of refresh 
from vc-diff output might be the best solution.

> This email is intended only for the person to whom it is addressed and may contain confidential information. Any retransmission, copying, disclosure or other use of, this information by persons other than the intended recipient is prohibited. If you received this email in error, please contact the sender and delete the material. This email is for information only and is not intended as an offer or solicitation for the purchase or sale of any financial instrument. Wadhwani Asset Management LLP is a Limited Liability Partnership registered in England (OC303168) with registered office at 40 Berkeley Square, 3rd Floor, London, W1J 5AL. It is authorised and regulated by the Financial Conduct Authority.

Please drop this nonsense. The above text makes it seem like I can't 
even quote your message here because a copy goes to the public bug tracker.





      reply	other threads:[~2015-05-17  0:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 10:24 bug#19543: 24.4; vc-mode: 'Fileset is up-to-date' even when vc-diff showed differences Ed Avis
2015-05-16 14:41 ` Dmitry Gutov
2015-05-16 14:44   ` Dmitry Gutov
2015-05-16 16:19   ` Ed Avis
2015-05-17  0:32     ` Dmitry Gutov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5557E1B8.3080609@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=19543@debbugs.gnu.org \
    --cc=eda@waniasset.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.