From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Ludlam Newsgroups: gmane.emacs.bugs Subject: bug#20507: 25.0.50 eieio and packages depending on it Date: Tue, 05 May 2015 20:58:19 -0400 Message-ID: <5549672B.6090601@gmail.com> References: <20150505.100641.159216149369481177.devel@pollock-nageoire.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1430873963 5354 80.91.229.3 (6 May 2015 00:59:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 May 2015 00:59:23 +0000 (UTC) Cc: zappo@gnu.org, 20507@debbugs.gnu.org To: Stefan Monnier , Pierre Lorenzon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 06 02:59:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ypng7-0006It-Ur for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 May 2015 02:59:12 +0200 Original-Received: from localhost ([::1]:42448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypng7-0002Ba-FC for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 May 2015 20:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypng4-0002BT-5i for bug-gnu-emacs@gnu.org; Tue, 05 May 2015 20:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ypnfz-0008IS-0d for bug-gnu-emacs@gnu.org; Tue, 05 May 2015 20:59:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ypnfy-0008IK-UD for bug-gnu-emacs@gnu.org; Tue, 05 May 2015 20:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ypnfy-0002lc-Fj for bug-gnu-emacs@gnu.org; Tue, 05 May 2015 20:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Ludlam Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 May 2015 00:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20507-submit@debbugs.gnu.org id=B20507.143087391010598 (code B ref 20507); Wed, 06 May 2015 00:59:02 +0000 Original-Received: (at 20507) by debbugs.gnu.org; 6 May 2015 00:58:30 +0000 Original-Received: from localhost ([127.0.0.1]:35751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpnfS-0002kr-5t for submit@debbugs.gnu.org; Tue, 05 May 2015 20:58:30 -0400 Original-Received: from mail-vn0-f49.google.com ([209.85.216.49]:37029) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpnfP-0002kc-Sv for 20507@debbugs.gnu.org; Tue, 05 May 2015 20:58:28 -0400 Original-Received: by vnbg129 with SMTP id g129so18391745vnb.4 for <20507@debbugs.gnu.org>; Tue, 05 May 2015 17:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=78DwYUsVXMrppkc3VckL7RquYJ7aKqUSW0t+LJqmf/8=; b=eUCpP7oU2hSgPhqT+rSKTesAwjuyRoFx4jaO3FpCH3wMnjapmIRN8vc153j7c3fm2r xFxbwkIOhzIQMFZX3tNPvC6PbiUsvQs8JIoqx6Nj3g8uhTSwEdmm9/xU8+V5e5kk5mpD 3DZ00lGZOo/8vIEnv4SLu6hfuaxRrglf7weV5ihbY1JIIBasrifGW1GWfbduuudvC5w9 WtnNyvJVVmtna7wYcCedsMh9GQm4+6LN+Fu0cRTpQXl/I3N6KarYNZMFE+GuxdmGCpa2 8j8kdD23dxEkfKQ5ES3wCcT17TjjITuOlWAcCRbOcIcDYYqs4KM2bBGMtWDAfkyHhbTu /40g== X-Received: by 10.52.101.131 with SMTP id fg3mr33683603vdb.82.1430873902041; Tue, 05 May 2015 17:58:22 -0700 (PDT) Original-Received: from [192.168.1.202] (pool-71-184-198-118.bstnma.fios.verizon.net. [71.184.198.118]) by mx.google.com with ESMTPSA id j9sm38678vdi.28.2015.05.05.17.58.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2015 17:58:21 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102524 Archived-At: On 05/05/2015 02:56 PM, Stefan Monnier wrote: > >> >I think I am able to contribute to that. But please tell me >> >more precisely which are the goals so that I do not make >> >something that is not in the spec ! Or simply tell me if >> >there's a good place to know what has to be done with the eieio >> >project and all its dependencies. > Mostly what needs to be done is to make sure that old code still works, > and when it doesn't decide whether it should be fixed by changing EIEIO > to be more bug-compatible or by changing the old code. > Hi Stefan, CEDET has an extensive test suite, but most of it hasn't been merged into Emacs' tests. I suspect the easiest way for you to get some good coverage is to pull CEDET from the sourceforge repository, build it using your development version of Emacs, and then do: make utest-batch and when that works make itest-batch The unit tests were failing for me with Emacs 25 a couple months back and I fixed a bunch of issues to make it work with some of the planned changes to eieio. I'm not sure where it stands today as I haven't had time to mess with it recently. The tests include all the tools that use eieio, and exercise a wide range of features from Semantic's completion to the SRecode insertion macros. If you pass these tests, I'd have high confidence your eieio changes are in good shape. The unit tests usually only take a minute or so, but the interactive tests can take several minutes. The tests require you have many external tools installed which I assume you do, such as make, automake, gcc, and a few other things. Eric