From: Daniel Colascione <dancol@dancol.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Nicolas Petton <nicolas@petton.fr>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior
Date: Tue, 05 May 2015 11:04:46 -0700 [thread overview]
Message-ID: <5549063E.4090003@dancol.org> (raw)
In-Reply-To: <jwvd22eykyp.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On 05/05/2015 10:50 AM, Stefan Monnier wrote:
>>>> + (setf nmark (marker-position saved-mark))
>>> ^^^^
>>> Old habits die hard.
>> Should `setf' be avoided? Is it only when `setq' would do instead?
>
> Sorry, I guess `setf' work as well, here. I've just been bitten by
> bootstrapping problems too many times, but simple.el should be late
> enough that it can't be a problem.
There ought to be a file-local variable marking early-loadup files that
tells the compiler to warn about certain otherwise-safe facilities.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-05 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150504184829.1108.13525@vcs.savannah.gnu.org>
[not found] ` <E1YpLPp-0000IV-4c@vcs.savannah.gnu.org>
2015-05-04 22:16 ` [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior Stefan Monnier
2015-05-04 22:37 ` Daniel Colascione
2015-05-05 17:48 ` Stefan Monnier
2015-05-04 23:02 ` Nicolas Petton
2015-05-04 23:04 ` Daniel Colascione
2015-05-05 17:50 ` Stefan Monnier
2015-05-05 18:04 ` Daniel Colascione [this message]
2015-05-05 19:00 ` Stefan Monnier
2015-05-05 18:31 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5549063E.4090003@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.