From: Daniel Colascione <dancol@dancol.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior
Date: Mon, 04 May 2015 15:37:47 -0700 [thread overview]
Message-ID: <5547F4BB.1080804@dancol.org> (raw)
In-Reply-To: <jwvoam0c872.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
On 05/04/2015 03:16 PM, Stefan Monnier wrote:
>> + (let ((mark (mark-marker)))
>> + (and mark (marker-position mark) (copy-marker mark)))
>
> Here you consider that (mark-marker) can return nil.
>
>> +(defun save-mark-and-excursion--restore (saved-mark-info)
>> + (let ((saved-mark (car saved-mark-info))
>> + (omark (marker-position (mark-marker)))
>
> But here you assume it's always a marker.
It is always a marker, isn't it? Some other parts of simple.el assume it
always returns non-nil. I'll remove the nil check.
>> + (let ((cur-mark-active mark-active))
>> + (setf mark-active saved-mark-active)
>> + ;; If mark is active now, and either was not active or was at a
>> + ;; different place, run the activate hook.
>> + (if saved-mark-active
>> + (unless (eq omark nmark)
>> + (run-hooks 'activate-mark-hook))
>
> IIUC activate-mark-hook should also be run when (eq omark nmark) but
> cur-mark-active was nil.
Huh. I just mechanically translated the original save-excursion C code.
Doesn't that code have the same mismatch between the comment and the
behavior?
/* If mark is active now, and either was not active
or was at a different place, run the activate hook. */
tem = XSAVE_OBJECT (info, 3); // saved-mark-active
...
if (! NILP (tem))
{
if (! EQ (omark, nmark))
run_hook (intern ("activate-mark-hook"));
}
/* If mark has ceased to be active, run deactivate hook. */
else if (! NILP (tem1))
run_hook (intern ("deactivate-mark-hook"));
I'll change the code to match the comment.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-04 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150504184829.1108.13525@vcs.savannah.gnu.org>
[not found] ` <E1YpLPp-0000IV-4c@vcs.savannah.gnu.org>
2015-05-04 22:16 ` [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior Stefan Monnier
2015-05-04 22:37 ` Daniel Colascione [this message]
2015-05-05 17:48 ` Stefan Monnier
2015-05-04 23:02 ` Nicolas Petton
2015-05-04 23:04 ` Daniel Colascione
2015-05-05 17:50 ` Stefan Monnier
2015-05-05 18:04 ` Daniel Colascione
2015-05-05 19:00 ` Stefan Monnier
2015-05-05 18:31 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547F4BB.1080804@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.