From: Dmitry Gutov <dgutov@yandex.ru>
To: joaotavora@gmail.com (João Távora)
Cc: Vitalie Spinu <spinuvit@gmail.com>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: xref backends for elisp-related modes Was: Re: Bad moves with xref-find-definitions
Date: Sun, 26 Apr 2015 16:56:43 +0300 [thread overview]
Message-ID: <553CEE9B.9000702@yandex.ru> (raw)
In-Reply-To: <m1vbgjw1jv.fsf_-_@holy.lan>
On 04/26/2015 02:51 PM, joaotavora@gmail.com (João Távora) wrote:
> BTW the necessary level of indirection is already present with
> `advice-add': we needn't necessarily add more variables. I mean:
>
> (advice-add 'elisp-xref-find :override #'etags-xref-find)
Looks good enough to me. Indeed, maybe xref-etags-mode should be
replaced by a function that applies these advices.
> Should be enough and quite readable. Conversely, I wouldn't be very
> annoyed if etags were the default method of finding elisp xrefs. Then I
> would use advice-add to set my behaviour, perhaps by doing
I think elisp-xref-find is a better default.
> (advice-add 'elisp-xref-find :override
> #'elisp-compiled-identifier-locations) ; better name pending
This cannot be done globally (or it'll affect all buffers).
> Additionally, if `add-function' allowed `:append' for its WHERE arg,
> like Common Lisp's method combinations, it would be even cleaner to get
> the behaviour desired by Eli (and Vitalie, I think), of multiple
> backends.
>
> (advice-add 'elisp-xref-find :append #'etags-xref-find)
a: If we want it to do appending, that could be implemented in
`elisp-xref-find'. Or there could be a variant of it doing that.
b: This doesn't deal with duplicates, which I think is the main problem
if we were to go that way.
> It does, I know, but it would be a lot simpler, especially for functions
> spawning *Help* buffers, to just assume we're in an elisp-related
> context. Packages like SLIME or SLY or CIDER that make use of these
> major modes should be the ones overriding the backend.
Can we be sure that languages using the default backend (etags) and
expecting it to work in their help buffers, will be a negligible minority?
> +(defun elisp--setup-xref-backend ()
> + (setq-local xref-find-function #'elisp-xref-find)
> + (setq-local xref-identifier-completion-table-function
> + #'elisp--xref-identifier-completion-table))
Shouldn't this also include the dynamic declarations removed from
`emacs-lisp-mode'?
next prev parent reply other threads:[~2015-04-26 13:56 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 15:07 Bad moves with xref-find-definitions Vitalie Spinu
2015-04-25 14:24 ` Stefan Monnier
2015-04-25 16:25 ` Dmitry Gutov
2015-04-25 17:42 ` Vitalie Spinu
2015-04-25 18:49 ` Vitalie Spinu
2015-04-25 19:07 ` Dmitry Gutov
2015-04-25 18:56 ` João Távora
2015-04-25 23:50 ` Dmitry Gutov
2015-04-26 11:51 ` xref backends for elisp-related modes Was: " João Távora
2015-04-26 13:56 ` Dmitry Gutov [this message]
2015-04-26 14:51 ` Eli Zaretskii
2015-04-28 11:06 ` Vitalie Spinu
2015-04-28 11:41 ` João Távora
2015-04-28 11:59 ` Vitalie Spinu
2015-04-28 15:17 ` Eli Zaretskii
2015-04-28 15:45 ` Vitalie Spinu
2015-04-28 16:01 ` Eli Zaretskii
2015-04-28 13:27 ` Stefan Monnier
2015-04-28 21:28 ` Dmitry Gutov
2015-04-29 12:35 ` Vitalie Spinu
2015-04-29 15:45 ` Eli Zaretskii
2015-04-28 15:15 ` Eli Zaretskii
2015-04-28 15:47 ` Vitalie Spinu
2015-04-28 16:03 ` Eli Zaretskii
2015-04-29 6:55 ` Helmut Eller
2015-04-29 12:40 ` Vitalie Spinu
2015-04-29 13:01 ` Helmut Eller
2015-04-29 15:30 ` Vitalie Spinu
2015-04-29 17:09 ` Dmitry Gutov
2015-04-29 12:47 ` Dmitry Gutov
2015-04-29 13:04 ` Helmut Eller
2015-04-29 13:12 ` Dmitry Gutov
2015-04-27 2:20 ` Stefan Monnier
2015-04-25 19:11 ` Dmitry Gutov
2015-04-25 20:43 ` Vitalie Spinu
2015-04-26 3:37 ` Dmitry Gutov
2015-04-26 6:38 ` Bozhidar Batsov
2015-04-26 18:41 ` Dmitry Gutov
2015-04-27 19:36 ` Bozhidar Batsov
2015-04-28 1:23 ` Dmitry Gutov
2015-04-28 11:30 ` Vitalie Spinu
2015-04-26 10:44 ` Vitalie Spinu
2015-04-26 13:14 ` Vitalie Spinu
2015-04-26 15:09 ` Dmitry Gutov
2015-04-26 16:23 ` Vitalie Spinu
2015-04-26 17:51 ` Dmitry Gutov
2015-04-26 20:56 ` Vitalie Spinu
2015-04-27 21:57 ` Dmitry Gutov
2015-04-26 3:34 ` Stefan Monnier
2015-04-26 11:31 ` Vitalie Spinu
2015-04-26 14:50 ` Eli Zaretskii
2015-04-26 15:12 ` Dmitry Gutov
2015-04-26 15:32 ` Eli Zaretskii
2015-04-26 15:20 ` Dmitry Gutov
2015-04-26 16:01 ` Vitalie Spinu
2015-04-26 17:26 ` Dmitry Gutov
2015-04-27 2:26 ` Stefan Monnier
2015-04-25 19:01 ` Dmitry Gutov
2015-04-25 20:34 ` Vitalie Spinu
2015-04-25 21:44 ` Vitalie Spinu
2015-04-26 0:20 ` Dmitry Gutov
2015-04-26 0:28 ` Dmitry Gutov
2015-04-28 15:31 ` Vitalie Spinu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553CEE9B.9000702@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=spinuvit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.