From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Bad moves with xref-find-definitions Date: Sun, 26 Apr 2015 06:37:25 +0300 Message-ID: <553C5D75.9060706@yandex.ru> References: <87h9s6c27z.fsf@gmail.com> <87zj5wnlyt.fsf@gmail.com> <553BE6F2.4030604@yandex.ru> <87fv7ondlr.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1430019894 21480 80.91.229.3 (26 Apr 2015 03:44:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 26 Apr 2015 03:44:54 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Vitalie Spinu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 26 05:44:46 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YmDUs-0002ci-Hd for ged-emacs-devel@m.gmane.org; Sun, 26 Apr 2015 05:44:46 +0200 Original-Received: from localhost ([::1]:49811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmDUr-00006w-O6 for ged-emacs-devel@m.gmane.org; Sat, 25 Apr 2015 23:44:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmDUX-0008VG-0J for emacs-devel@gnu.org; Sat, 25 Apr 2015 23:44:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmDNy-0004sc-64 for emacs-devel@gnu.org; Sat, 25 Apr 2015 23:37:43 -0400 Original-Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:34597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmDNx-0004sQ-Vh for emacs-devel@gnu.org; Sat, 25 Apr 2015 23:37:38 -0400 Original-Received: by wgso17 with SMTP id o17so85094431wgs.1 for ; Sat, 25 Apr 2015 20:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=NVvWB4eSezx+bfr2wPqD81wvGB1G0yfQgi282q5MxIY=; b=dvz5gnWnj5bu4IaQ0ZjcYxvaRqGC42bgELWptYcrNwF1UxlfLU4Z5PjPHFbiOQiTLq lgcwx9uZkr/LUS5n89HtbNDyk8fSKEYbl/5sDpxVMMCXQ+lKbw7ZXcVDFTK/XummbxoN sbHbrev3Ylq3DRyHwuGezOnu+ms6Y+pHh2B+UJwbZJl1o/33N8D5jENJj68gqn6tCsaW FUp1bzOAXr/v1QZw4njQsswlGHP8EN5VECSZjW29YfF7BKIIAWJXPg5LtEKcYDbL1lcD KeRqTAE0hRkRcF8H2TYtjOcRAPNJjmkKXcxULLbYa4xm4Kf2HUFXvaxx5djz/niTZtSt ToUg== X-Received: by 10.180.208.42 with SMTP id mb10mr9322974wic.80.1430019448348; Sat, 25 Apr 2015 20:37:28 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id vz8sm2583432wjc.27.2015.04.25.20.37.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Apr 2015 20:37:28 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: <87fv7ondlr.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185899 Archived-At: On 04/25/2015 11:43 PM, Vitalie Spinu wrote: > It probably should be generic such that other "finding" or "jumping" > functionality can reuse it (prompt-before-jump, auto-jump). Maybe the rule could be whether the command is almost always related to the current buffer's contents. `describe-function' and friends I would actually consider to be counter-examples, because they only work with Elisp. And similarly how certain other people are attached to etags, I'd always want to have access to Elisp documentation and sources, even when editing unrelated code in another language. Hence I think we need a separate, generalizable command and binding that would work with different modes and depend on the current language or project. That one could work like SLIME's `C-c C-d C-d'. > The problem is of course that "find-file" is also a "finding" behavior, > for which you unlikely to want this behavior. So it's difficult to draw > a line on what are these commands. Let's stop at xref, for now. > More specific name like xref-auto-jump seems quite suggestive to me. How about `xref-prompt-for-identifier', to mirror CIDER's option name?