From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: 20401@debbugs.gnu.org
Subject: bug#20401: refill long lines in generated ChangeLog
Date: Sat, 25 Apr 2015 18:24:23 -0700 [thread overview]
Message-ID: <553C3E47.9090404@cs.ucla.edu> (raw)
In-Reply-To: <emegndcimf.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
> it's not just me that has written lines slightly too long.
That's right, lots of people are doing it, and it makes more busywork when
cleaning up ChangeLogs, which sucks. I don't have much faith in fixing this
automagically, as a lot could go wrong.
There's a much simpler fix (see attached) but Stefan nixed it (see
<http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg01640.html>) for
reasons that I don't follow. Perhaps we could take another run at him and he'll
relent this time.
Another possibility is that we set the tab-width in ChangeLog files to 2, so
that 78-character log lines fit in ChangeLog files when displayed via Emacs.
(I'm *sure* nobody would complain about *that*. :-)
But really, it'd be simpler to shrink that "78" back to "72".
[-- Attachment #2: 0001-Encourage-shorter-commit-message-lines.patch --]
[-- Type: text/x-patch, Size: 938 bytes --]
From 9ba2c1fc35590c41fba623f892af7dd9c75e5f5b Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 25 Apr 2015 18:14:35 -0700
Subject: [PATCH] Encourage shorter commit message lines
This helps keep generated ChangeLog lines less than 80 characters
(Bug#20401).
* build-aux/git-hooks/commit-msg: Limit lines to 72 characters.
---
build-aux/git-hooks/commit-msg | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/build-aux/git-hooks/commit-msg b/build-aux/git-hooks/commit-msg
index 9661376..5e46d9f 100755
--- a/build-aux/git-hooks/commit-msg
+++ b/build-aux/git-hooks/commit-msg
@@ -110,8 +110,8 @@ exec $awk -v at_sign="$at_sign" -v cent_sign="$cent_sign" '
}
}
- 78 < length && $0 ~ space {
- print "Line longer than 78 characters in commit message"
+ 72 < length && $0 ~ space {
+ print "Line longer than 72 characters in commit message"
status = 1
}
--
2.1.0
next prev parent reply other threads:[~2015-04-26 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 20:48 bug#20401: refill long lines in generated ChangeLog Glenn Morris
2015-04-26 1:24 ` Paul Eggert [this message]
2015-04-27 18:25 ` Glenn Morris
2015-04-27 18:37 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553C3E47.9090404@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=20401@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.