bug#20353: M-. sometimes jumps in another window

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

> Right, the remembering might be part of pop-to-buffer and quit-window
> rather than part of xref.  Either way is fine by me.

Would the attached patch fix it?

martin



[-- Attachment #2: quit-window.diff --]
[-- Type: text/plain, Size: 857 bytes --]

--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5474,10 +5474,15 @@ element is BUFFER."
   (cond
    ((eq type 'reuse)
     (if (eq (window-buffer window) buffer)
-	;; WINDOW shows BUFFER already.
-	(when (consp (window-parameter window 'quit-restore))
-	  ;; If WINDOW has a quit-restore parameter, reset its car.
-	  (setcar (window-parameter window 'quit-restore) 'same))
+	;; WINDOW shows BUFFER already.  Update WINDOW's quit-restore
+	;; parameter, if any.
+	(let ((old (window-parameter window 'quit-restore)))
+	  (when (consp old)
+	    (set-window-parameter
+	     window 'quit-restore
+	     ;; The selected-window might have changed in between
+	     ;; (Bug#20353).
+	     (list 'same (nth 1 old) (selected-window) (nth 3 old)))))
       ;; WINDOW shows another buffer.
       (with-current-buffer (window-buffer window)
 	(set-window-parameter