From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 6a098c6 15/19: Add ivy-mode Date: Sat, 18 Apr 2015 00:07:24 +0300 Message-ID: <5531760C.80305@yandex.ru> References: <20150416121807.21266.28456@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1429304868 22854 80.91.229.3 (17 Apr 2015 21:07:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 21:07:48 +0000 (UTC) Cc: Oleh Krehel To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 17 23:07:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjDUE-0002Ks-7g for ged-emacs-devel@m.gmane.org; Fri, 17 Apr 2015 23:07:42 +0200 Original-Received: from localhost ([::1]:43527 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDUD-0004HZ-Gd for ged-emacs-devel@m.gmane.org; Fri, 17 Apr 2015 17:07:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDU8-0004HG-W9 for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:07:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjDTz-0006ZH-VT for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:07:36 -0400 Original-Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:34143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjDTz-0006ZB-Og for emacs-devel@gnu.org; Fri, 17 Apr 2015 17:07:27 -0400 Original-Received: by widjs5 with SMTP id js5so42159402wid.1 for ; Fri, 17 Apr 2015 14:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=/7zpvGCC3txshG8FjLS3gCTSEpWIoFknfmlqz63AXZI=; b=LKMX260YWigofU2MZ21EJ40qtLMqEgawgWZa9XcdiBsfmvVnBiAY1UYFptgZJqSrfL g/XcHXN8Hb5KwpGiTShReOp/KMC4Bu38ejVEYT0FzvSXmHvpUQ8hXk1IDIzIQYH1SoOJ yUkdkVKn611lw9Dokq6hgsiCwquByw+oYVxrgNhBE/v5geFhAro8qBPHQ8BI9UtXBuph jO6SLvJnC5yTo+ROTwW+eZ8zORo9M+Jr6Nk9XpBg5mVXOvx2e/ZRbgzk0q6w9gDlxVr+ RPoKCwqNjxrOYBfE0pOWmhve4uu0Ktq15e2u/K/vPv31Ehp75Dx4eEAmhsLLibkAt4J2 b6jg== X-Received: by 10.194.156.202 with SMTP id wg10mr9504378wjb.70.1429304847120; Fri, 17 Apr 2015 14:07:27 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id hu1sm4191213wib.6.2015.04.17.14.07.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Apr 2015 14:07:26 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185542 Archived-At: On 04/16/2015 04:37 PM, Stefan Monnier wrote: >> + (cond ((functionp collection) >> + (error "Function as a collection unsupported")) >> + ((hash-table-p collection) >> + (error "Hash table as a collection unsupported")) >> + ((listp (car collection)) >> + (setq collection (mapcar #'car collection)))) > [...] >> + (setq completing-read-function 'ivy-completing-read) > > Since completion-tables in the form of a function are pretty common > nowadays (and becoming every time more frequent), this is a real > problem It also needs to support obarrays, to be useful with e.g. `describe-function'.