From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20323: 25.0.50; Emacs's .dir-locals.el should set indent-tabs-mode to nil for emacs-lisp-mode and c-mode Date: Thu, 16 Apr 2015 23:59:20 +0300 Message-ID: <553022A8.4080705@yandex.ru> References: <86y4lv1kyy.fsf@yandex.ru> <552D0511.7000903@yandex.ru> <552D950F.5090602@yandex.ru> <3rwq1bommd.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1429218031 29683 80.91.229.3 (16 Apr 2015 21:00:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Apr 2015 21:00:31 +0000 (UTC) Cc: 20323@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 16 23:00:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YiqtU-0004pa-Bh for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Apr 2015 23:00:16 +0200 Original-Received: from localhost ([::1]:38548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiqtT-00087a-B0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Apr 2015 17:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiqtP-00087E-Ef for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2015 17:00:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiqtL-0001KF-1M for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2015 17:00:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiqtK-0001IT-UU for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2015 17:00:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YiqtJ-0006hH-Kh for bug-gnu-emacs@gnu.org; Thu, 16 Apr 2015 17:00:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Apr 2015 21:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20323-submit@debbugs.gnu.org id=B20323.142921797525668 (code B ref 20323); Thu, 16 Apr 2015 21:00:05 +0000 Original-Received: (at 20323) by debbugs.gnu.org; 16 Apr 2015 20:59:35 +0000 Original-Received: from localhost ([127.0.0.1]:58392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yiqsp-0006fv-3E for submit@debbugs.gnu.org; Thu, 16 Apr 2015 16:59:35 -0400 Original-Received: from mail-wg0-f49.google.com ([74.125.82.49]:34073) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yiqsn-0006fi-5k for 20323@debbugs.gnu.org; Thu, 16 Apr 2015 16:59:33 -0400 Original-Received: by wgso17 with SMTP id o17so94198147wgs.1 for <20323@debbugs.gnu.org>; Thu, 16 Apr 2015 13:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=/Laf1tSGfuNkdp04aYSIlY4g8z4ySIh/NyzvvZTZTUA=; b=t6H7+s9gSs19QWuW+VgcJezcDtPBy3PtnlVmAitLzeUOQvyAMVrW0sgsxaX7dXRGLD C8RU9kAsXUV9g8j72tMTwtVk2QoUnmebeD2wxnoTRXH4nASUBtSuj8BltzZQ9C1cVEeS t2mI943XnJUYnT2XqZ0okVBc5xsG2Yl1szkw0oJmMFX757p4NuEzdNhHK68FcxuKj1FK 04WINvM/DAeawBQObNSC0oMO7bz0cFdxV22jQ9dqzQ47JG5ZXZ835g2HeUNZQr91TfA3 TBUHH86Y3TnlY0HuuRwV2wmzetyn6jD4m7JNJfpyotNRDKTExCJmpV0y+mEL30IinlJu 0qpQ== X-Received: by 10.180.99.42 with SMTP id en10mr37809wib.83.1429217967210; Thu, 16 Apr 2015 13:59:27 -0700 (PDT) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id k6sm27544272wia.6.2015.04.16.13.59.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 13:59:25 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: <3rwq1bommd.fsf@fencepost.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101599 Archived-At: On 04/16/2015 11:15 PM, Glenn Morris wrote: > > I've long since done what seems to me to be the sensible thing: > > use a mode-hook to set indent-tabs-mode to whatever the (pre-existing) > file I'm editing seems to use. > > I won't claim it's always right (for those files where the indentation > is mixed), but it's worked pretty well for me. That sounds like a great approach, but not for this case. > The fact that indent-tabs-mode has been added to dir-locals now breaks > this, since dir-locals take precedence over mode hooks (bug#1986). Why is that a problem? If dir-locals take precedence, then the result will be that your commits won't use tabs, except in certain subprojects like gnus or erc, which have set file-local vars differently. That's the original intent behind this proposal: to converge all .el files to one indentation style, eventually. > So for me, this change increases the likelihood of me committing stuff > that does not match the existing indentation style. Ie, adding it to > dir-locals without untabifying every file (something which has already > been rejected) has made things worse IMO. You seen to consider the presence of different indentation styles in any specific file to be the main problem. I disagree: most files already contain both styles, and having different styles within the project is not much better.