all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Glenn Morris <rgm@gnu.org>
Cc: 20323@debbugs.gnu.org
Subject: bug#20323: 25.0.50; Emacs's .dir-locals.el should set indent-tabs-mode to nil for emacs-lisp-mode and c-mode
Date: Thu, 16 Apr 2015 23:59:20 +0300	[thread overview]
Message-ID: <553022A8.4080705@yandex.ru> (raw)
In-Reply-To: <3rwq1bommd.fsf@fencepost.gnu.org>

On 04/16/2015 11:15 PM, Glenn Morris wrote:
>
> I've long since done what seems to me to be the sensible thing:
>
>    use a mode-hook to set indent-tabs-mode to whatever the (pre-existing)
>    file I'm editing seems to use.
>
> I won't claim it's always right (for those files where the indentation
> is mixed), but it's worked pretty well for me.

That sounds like a great approach, but not for this case.

> The fact that indent-tabs-mode has been added to dir-locals now breaks
> this, since dir-locals take precedence over mode hooks (bug#1986).

Why is that a problem? If dir-locals take precedence, then the result 
will be that your commits won't use tabs, except in certain subprojects 
like gnus or erc, which have set file-local vars differently.

That's the original intent behind this proposal: to converge all .el 
files to one indentation style, eventually.

> So for me, this change increases the likelihood of me committing stuff
> that does not match the existing indentation style. Ie, adding it to
> dir-locals without untabifying every file (something which has already
> been rejected) has made things worse IMO.

You seen to consider the presence of different indentation styles in any 
specific file to be the main problem. I disagree: most files already 
contain both styles, and having different styles within the project is 
not much better.





  reply	other threads:[~2015-04-16 20:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  2:51 bug#20323: 25.0.50; Emacs's .dir-locals.el should set indent-tabs-mode to nil for emacs-lisp-mode and c-mode Dmitry Gutov
2015-04-14  3:09 ` Stefan Monnier
2015-04-14 12:16   ` Dmitry Gutov
2015-04-14 16:57     ` Stefan Monnier
2015-04-14 22:30       ` Dmitry Gutov
2015-04-16 20:15         ` Glenn Morris
2015-04-16 20:59           ` Dmitry Gutov [this message]
2015-04-16 21:30           ` Stefan Monnier
2020-01-15  5:17         ` Stefan Kangas
2020-01-15  8:21           ` Robert Pluim
2020-01-15 16:20           ` Eli Zaretskii
2020-01-15 18:12             ` Stefan Kangas
2020-01-16  9:46               ` Robert Pluim
2020-01-16 13:38                 ` Stefan Kangas
2020-02-28 23:06                   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553022A8.4080705@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=20323@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.