From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: commit-msg hook
Date: Tue, 14 Apr 2015 11:32:51 -0700 [thread overview]
Message-ID: <552D5D53.2020800@cs.ucla.edu> (raw)
In-Reply-To: <83618ybncm.fsf@gnu.org>
On 04/14/2015 11:01 AM, Eli Zaretskii wrote:
> You mean, like below?
Looks good, yes. Some nits:
>
> --- ./.git/hooks/commit-msg.~5~ 2015-04-12 19:11:27.481125000 +0300
> +++ ./.git/hooks/commit-msg 2015-04-14 21:01:14.481125000 +0300
> @@ -37,6 +37,8 @@
> at_sign=`LC_ALL=en_US.UTF-8 $awk "$print_at_sign" </dev/null 2>/dev/null`
> if test "$at_sign" = @; then
> LC_ALL=en_US.UTF-8; export LC_ALL
> + else
> + LC_ALL=C; export LC_ALL
> fi
> fi
>
The duplicate 'export LC_ALL's can be hoisted out of the 'if'.
> + non_print = "[\1-\37\177]|\302[\200-\237]|\355([\240-\257]|[\260-\277])[\200-\277]"
>
>
"([\240-\257]|[\260-\277])" can be simplified to "[\240-\277]".
next prev parent reply other threads:[~2015-04-14 18:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 10:43 commit-msg hook Eli Zaretskii
2015-04-10 18:23 ` Johan Bockgård
2015-04-11 2:42 ` Paul Eggert
2015-04-11 7:24 ` Eli Zaretskii
2015-04-11 9:55 ` Eli Zaretskii
2015-04-11 9:59 ` Eli Zaretskii
2015-04-11 12:42 ` Dmitry Gutov
2015-04-11 14:29 ` Eli Zaretskii
2015-04-11 15:13 ` Dmitry Gutov
2015-04-11 15:17 ` Eli Zaretskii
2015-04-12 3:36 ` Stefan Monnier
2015-04-12 18:54 ` chad
2015-04-11 15:40 ` Paul Eggert
2015-04-11 16:40 ` Eli Zaretskii
2015-04-11 20:09 ` Paul Eggert
2015-04-12 16:10 ` Eli Zaretskii
2015-04-13 15:48 ` Eli Zaretskii
2015-04-13 18:37 ` Paul Eggert
2015-04-13 20:18 ` Eli Zaretskii
2015-04-13 21:19 ` Paul Eggert
2015-04-14 15:08 ` Eli Zaretskii
2015-04-14 17:01 ` Paul Eggert
2015-04-14 17:09 ` Eli Zaretskii
2015-04-14 17:42 ` Paul Eggert
2015-04-14 18:01 ` Eli Zaretskii
2015-04-14 18:32 ` Paul Eggert [this message]
2015-04-14 18:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552D5D53.2020800@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.