Crash with tests

Crash with tests

[Fabrice Popineau]

Hi,

Does anybody see this problem with the current trunk  (commit 
b5919771aea2d43c64be381b7d7b395eeb1191bd) ?
Emacs is crashing a couple of times while running tests.
Here is a backtrace for one of the crashes.

Best regards,

Fabrice


(gdb) run -Q -batch -l ert -l ert-x-tests.el -f ert-run-tests-batch-and-exit
Starting program: /c/source/Gnu/emacs/build-x64/src/emacs-25.0.50.3.exe -Q -
batch -l ert -l ert-x-tests.el -f ert-run-tests-batch-and-exit
[New Thread 23468.0x41f4]
warning: SHIMVIEW: ShimInfo(Complete)
[New Thread 23468.0x5b70]
Running 9 tests (2015-04-14 11:29:41+0200)
   passed  1/9  ert-filter-string
   passed  2/9  ert-propertized-string
Indenting region...
Indenting region...done
Indenting region...
Indenting region...done
   passed  3/9  ert-test-buffer-string-reindented
foo
0
1
2
3

Test message
   passed  4/9  ert-test-builtin-message-log-flushing
Type C-x 1 to delete the help window, C-M-v to scroll help.
   passed  5/9  ert-test-describe-test
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
0
1
2
   passed  6/9  ert-test-force-message-log-buffer-truncation
a
b
c
d
   passed  7/9  ert-test-message-log-truncation

Program received signal SIGSEGV, Segmentation fault.
0x00000004000a20a7 in save_window_save (window=17186846885,
    vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
    at ../../emacs/src/window.c:6607
6607          p->window = window;
(gdb) backtrace
#0  0x00000004000a20a7 in save_window_save (window=17186846885,
    vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
    at ../../emacs/src/window.c:6607
#1  0x00000004000a2cfc in Fcurrent_window_configuration (frame=0)
    at ../../emacs/src/window.c:6766
#2  0x00000004001cafa0 in Ffuncall (nargs=1, args=0x8392c8)
    at ../../emacs/src/eval.c:2718
#3  0x0000000400214d71 in exec_byte_code (bytestr=43505364,
    vector=17189494861, maxdepth=38, args_template=1030, nargs=1,
    args=0x839858) at ../../emacs/src/bytecode.c:919
#4  0x00000004001cb91f in funcall_lambda (fun=17189491229, nargs=1,
    arg_vector=0x839850) at ../../emacs/src/eval.c:2885
#5  0x00000004001cb31c in Ffuncall (nargs=2, args=0x839848)
    at ../../emacs/src/eval.c:2767
#6  0x0000000400214d71 in exec_byte_code (bytestr=43506836,
    vector=17189495285, maxdepth=54, args_template=1030, nargs=1,
    args=0x839df0) at ../../emacs/src/bytecode.c:919
#7  0x00000004001cb91f in funcall_lambda (fun=17189498709, nargs=1,
    arg_vector=0x839de8) at ../../emacs/src/eval.c:2885
#8  0x00000004001cb31c in Ffuncall (nargs=2, args=0x839de0)
    at ../../emacs/src/eval.c:2767
#9  0x0000000400214d71 in exec_byte_code (bytestr=43547668,
    vector=17189794773, maxdepth=58, args_template=3086, nargs=3,
---Type <return> to continue, or q <return> to quit---
    args=0x83a3b0) at ../../emacs/src/bytecode.c:919
#10 0x00000004001cb91f in funcall_lambda (fun=17189540685, nargs=3,
    arg_vector=0x83a398) at ../../emacs/src/eval.c:2885
#11 0x00000004001cb31c in Ffuncall (nargs=4, args=0x83a390)
    at ../../emacs/src/eval.c:2767
#12 0x0000000400214d71 in exec_byte_code (bytestr=43557028,
    vector=17189795045, maxdepth=54, args_template=2058, nargs=2,
    args=0x83a938) at ../../emacs/src/bytecode.c:919
#13 0x00000004001cb91f in funcall_lambda (fun=17189795229, nargs=2,
    arg_vector=0x83a928) at ../../emacs/src/eval.c:2885
#14 0x00000004001cb31c in Ffuncall (nargs=3, args=0x83a920)
    at ../../emacs/src/eval.c:2767
#15 0x0000000400214d71 in exec_byte_code (bytestr=43621844,
    vector=17189832125, maxdepth=70, args_template=3078, nargs=3,
    args=0x83adc8) at ../../emacs/src/bytecode.c:919
#16 0x00000004001cb91f in funcall_lambda (fun=17189832221, nargs=3,
    arg_vector=0x83adb0) at ../../emacs/src/eval.c:2885
#17 0x00000004001cb6b7 in apply_lambda (fun=17189832221, args=43768387,
    count=55) at ../../emacs/src/eval.c:2826
#18 0x00000004001c9af5 in eval_sub (form=43768371)
    at ../../emacs/src/eval.c:2226
#19 0x00000004001c57d1 in Fprogn (body=43768435) at ../../emacs/src/eval.c:445
#20 0x00000004001c6a64 in Flet (args=43755699) at ../../emacs/src/eval.c:966
---Type <return> to continue, or q <return> to quit---
#21 0x00000004001c9597 in eval_sub (form=43755715)
    at ../../emacs/src/eval.c:2131
#22 0x00000004001c70d3 in Funwind_protect (args=43755747)
    at ../../emacs/src/eval.c:1206
#23 0x00000004001c9597 in eval_sub (form=43755731)
    at ../../emacs/src/eval.c:2131
#24 0x00000004001c57d1 in Fprogn (body=43755971) at ../../emacs/src/eval.c:445
#25 0x00000004001c9597 in eval_sub (form=43755955)
    at ../../emacs/src/eval.c:2131
#26 0x00000004001c70d3 in Funwind_protect (args=43756003)
    at ../../emacs/src/eval.c:1206
#27 0x00000004001c9597 in eval_sub (form=43755987)
    at ../../emacs/src/eval.c:2131
#28 0x00000004001c57d1 in Fprogn (body=43756051) at ../../emacs/src/eval.c:445
#29 0x00000004001c6a64 in Flet (args=43756067) at ../../emacs/src/eval.c:966
#30 0x00000004001c9597 in eval_sub (form=43756083)
    at ../../emacs/src/eval.c:2131
#31 0x00000004001c57d1 in Fprogn (body=43756115) at ../../emacs/src/eval.c:445
#32 0x00000004001c9597 in eval_sub (form=43756099)
    at ../../emacs/src/eval.c:2131
#33 0x00000004001c57d1 in Fprogn (body=43756131) at ../../emacs/src/eval.c:445
#34 0x00000004001c6695 in FletX (args=43783651) at ../../emacs/src/eval.c:896
#35 0x00000004001c9597 in eval_sub (form=43783667)
---Type <return> to continue, or q <return> to quit---
    at ../../emacs/src/eval.c:2131
#36 0x00000004001c57d1 in Fprogn (body=43783683) at ../../emacs/src/eval.c:445
#37 0x00000004001c6695 in FletX (args=43783699) at ../../emacs/src/eval.c:896
#38 0x00000004001c9597 in eval_sub (form=43783715)
    at ../../emacs/src/eval.c:2131
#39 0x00000004001c57d1 in Fprogn (body=43783763) at ../../emacs/src/eval.c:445
#40 0x00000004001cbc12 in funcall_lambda (fun=43783731, nargs=0,
    arg_vector=0x83c3f8) at ../../emacs/src/eval.c:2944
#41 0x00000004001cb419 in Ffuncall (nargs=1, args=0x83c3f0)
    at ../../emacs/src/eval.c:2779
#42 0x0000000400214d71 in exec_byte_code (bytestr=43505364,
    vector=17189494861, maxdepth=38, args_template=1030, nargs=1,
    args=0x83c978) at ../../emacs/src/bytecode.c:919
#43 0x00000004001cb91f in funcall_lambda (fun=17189491229, nargs=1,
    arg_vector=0x83c970) at ../../emacs/src/eval.c:2885
#44 0x00000004001cb31c in Ffuncall (nargs=2, args=0x83c968)
    at ../../emacs/src/eval.c:2767
#45 0x0000000400214d71 in exec_byte_code (bytestr=43506836,
    vector=17189495285, maxdepth=54, args_template=1030, nargs=1,
    args=0x83cf10) at ../../emacs/src/bytecode.c:919
#46 0x00000004001cb91f in funcall_lambda (fun=17189498709, nargs=1,
    arg_vector=0x83cf08) at ../../emacs/src/eval.c:2885
#47 0x00000004001cb31c in Ffuncall (nargs=2, args=0x83cf00)
---Type <return> to continue, or q <return> to quit---
    at ../../emacs/src/eval.c:2767
#48 0x0000000400214d71 in exec_byte_code (bytestr=43547668,
    vector=17189794773, maxdepth=58, args_template=3086, nargs=3,
    args=0x83d4d0) at ../../emacs/src/bytecode.c:919
#49 0x00000004001cb91f in funcall_lambda (fun=17189540685, nargs=3,
    arg_vector=0x83d4b8) at ../../emacs/src/eval.c:2885
#50 0x00000004001cb31c in Ffuncall (nargs=4, args=0x83d4b0)
    at ../../emacs/src/eval.c:2767
#51 0x0000000400214d71 in exec_byte_code (bytestr=43557028,
    vector=17189795045, maxdepth=54, args_template=2058, nargs=2,
    args=0x83da28) at ../../emacs/src/bytecode.c:919
#52 0x00000004001cb91f in funcall_lambda (fun=17189795229, nargs=2,
    arg_vector=0x83da18) at ../../emacs/src/eval.c:2885
#53 0x00000004001cb31c in Ffuncall (nargs=3, args=0x83da10)
    at ../../emacs/src/eval.c:2767
#54 0x0000000400214d71 in exec_byte_code (bytestr=43561732,
    vector=17189532541, maxdepth=18, args_template=1026, nargs=1,
    args=0x83df70) at ../../emacs/src/bytecode.c:919
#55 0x00000004001cb91f in funcall_lambda (fun=17189803789, nargs=1,
    arg_vector=0x83df68) at ../../emacs/src/eval.c:2885
#56 0x00000004001cb31c in Ffuncall (nargs=2, args=0x83df60)
    at ../../emacs/src/eval.c:2767
#57 0x0000000400214d71 in exec_byte_code (bytestr=43565412,
---Type <return> to continue, or q <return> to quit---
    vector=17189799389, maxdepth=22, args_template=1026, nargs=0,
    args=0x83e520) at ../../emacs/src/bytecode.c:919
#58 0x00000004001cb91f in funcall_lambda (fun=17189803917, nargs=0,
    arg_vector=0x83e520) at ../../emacs/src/eval.c:2885
#59 0x00000004001cb31c in Ffuncall (nargs=1, args=0x83e518)
    at ../../emacs/src/eval.c:2767
#60 0x0000000400214d71 in exec_byte_code (bytestr=17184088972,
    vector=17184089005, maxdepth=94, args_template=1030, nargs=1,
    args=0x83ea98) at ../../emacs/src/bytecode.c:919
#61 0x00000004001cb91f in funcall_lambda (fun=17184088925, nargs=1,
    arg_vector=0x83ea90) at ../../emacs/src/eval.c:2885
#62 0x00000004001cb31c in Ffuncall (nargs=2, args=0x83ea88)
    at ../../emacs/src/eval.c:2767
#63 0x0000000400214d71 in exec_byte_code (bytestr=17184065740,
    vector=17184065773, maxdepth=74, args_template=2, nargs=0, args=0x83f058)
    at ../../emacs/src/bytecode.c:919
#64 0x00000004001cb91f in funcall_lambda (fun=17184065693, nargs=0,
    arg_vector=0x83f058) at ../../emacs/src/eval.c:2885
#65 0x00000004001cb31c in Ffuncall (nargs=1, args=0x83f050)
    at ../../emacs/src/eval.c:2767
#66 0x0000000400214d71 in exec_byte_code (bytestr=17184062724,
    vector=17184062757, maxdepth=50, args_template=2, nargs=0, args=0x83f4f0)
    at ../../emacs/src/bytecode.c:919
---Type <return> to continue, or q <return> to quit---
#67 0x00000004001cb91f in funcall_lambda (fun=17184062677, nargs=0,
    arg_vector=0x83f4f0) at ../../emacs/src/eval.c:2885
#68 0x00000004001cb6b7 in apply_lambda (fun=17184062677, args=0, count=3)
    at ../../emacs/src/eval.c:2826
#69 0x00000004001c9af5 in eval_sub (form=17188237859)
    at ../../emacs/src/eval.c:2226
#70 0x00000004001c8fb6 in Feval (form=17188237859, lexical=0)
    at ../../emacs/src/eval.c:1996
#71 0x0000000400121ce6 in top_level_2 () at ../../emacs/src/keyboard.c:1148
#72 0x00000004001c777a in internal_condition_case (
    bfun=0x400121cbf <top_level_2>, handlers=23352,
    hfun=0x4001216f3 <cmd_error>) at ../../emacs/src/eval.c:1348
#73 0x0000000400121d32 in top_level_1 (ignore=0)
    at ../../emacs/src/keyboard.c:1156
#74 0x00000004001c6ea2 in internal_catch (tag=59304,
    func=0x400121ceb <top_level_1>, arg=0) at ../../emacs/src/eval.c:1108
#75 0x0000000400121c08 in command_loop () at ../../emacs/src/keyboard.c:1117
#76 0x0000000400121256 in recursive_edit_1 () at ../../emacs/src/keyboard.c:728
#77 0x0000000400121409 in Frecursive_edit () at ../../emacs/src/keyboard.c:799
#78 0x000000040011eb59 in main (argc=9, argv=0xbc6df0)
    at ../../emacs/src/emacs.c:1626

Lisp Backtrace:
---Type <return> to continue, or q <return> to quit---
"current-window-configuration" (0x8392d0)
"ert--run-test-internal" (0x839850)
"ert-run-test" (0x839de8)
"ert-run-or-rerun-test" (0x83a398)

"ert-run-tests" (0x83a928)
"ert-run-tests-interactively" (0x83adb0)
"let" (0x83b238)
"unwind-protect" (0x83b3f8)

"progn" (0x83b5c8)
"unwind-protect" (0x83b788)
"let" (0x83ba58)
"progn" (0x83bc28)

"let*" (0x83beb8)
"let*" (0x83c148)
0x29c1630 Lisp type 3
"ert--run-test-internal" (0x83c970)
"ert-run-test" (0x83cf08)
"ert-run-or-rerun-test" (0x83d4b8)
"ert-run-tests" (0x83da18)
"ert-run-tests-batch" (0x83df68)
"ert-run-tests-batch-and-exit" (0x83e520)
"command-line-1" (0x83ea90)
"command-line" (0x83f058)
---Type <return> to continue, or q <return> to quit---
"normal-top-level" (0x83f4f0)

Re: Crash with tests

[Eli Zaretskii]

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Tue, 14 Apr 2015 09:46:17 +0000 (UTC)
> 
> Does anybody see this problem with the current trunk  (commit 
> b5919771aea2d43c64be381b7d7b395eeb1191bd) ?
> Emacs is crashing a couple of times while running tests.

I don't see it.

> Program received signal SIGSEGV, Segmentation fault.
> 0x00000004000a20a7 in save_window_save (window=17186846885,
>     vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
>     at ../../emacs/src/window.c:6607
> 6607          p->window = window;

What is the value of 'p' here?

Re: Crash with tests

[Fabrice Popineau]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Program received signal SIGSEGV, Segmentation fault.
0x00000004000a20a7 in save_window_save (window=17186846885,
    vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
    at ../../emacs/src/window.c:6607
6607
(gdb) p/x p
$1 = 0x4000000001013ffb

And obviously, memory is not readable at this location.

When you say you don't see it: is it using 32bits or 64bits emacs ?

Fabrice

2015-04-14 17:53 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:

> > From: Fabrice Popineau <fabrice.popineau@gmail.com>
> > Date: Tue, 14 Apr 2015 09:46:17 +0000 (UTC)
> >
> > Does anybody see this problem with the current trunk  (commit
> > b5919771aea2d43c64be381b7d7b395eeb1191bd) ?
> > Emacs is crashing a couple of times while running tests.
>
> I don't see it.
>
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x00000004000a20a7 in save_window_save (window=17186846885,
> >     vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
> >     at ../../emacs/src/window.c:6607
> > 6607          p->window = window;
>
> What is the value of 'p' here?
>

[-- Attachment #2: Type: text/html, Size: 1650 bytes --]

Re: Crash with tests

[Eli Zaretskii]

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Tue, 14 Apr 2015 18:09:51 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x00000004000a20a7 in save_window_save (window=17186846885,
> vector=0x4009fb0d0 <dumped_data+3587600>, i=4)
> at ../../emacs/src/window.c:6607
> 6607
> (gdb) p/x p
> $1 = 0x4000000001013ffb
> 
> And obviously, memory is not readable at this location.

Yes.  So does it mean the vector-like object from which this came is
corrupted?

> When you say you don't see it: is it using 32bits or 64bits emacs ?

32-bit, the only one I have.

Re: Crash with tests

[Paul Eggert]

On 04/14/2015 09:37 AM, Eli Zaretskii wrote:
>> (gdb) p/x p
>> >$1 = 0x4000000001013ffb
>> >
>> >And obviously, memory is not readable at this location.
> Yes.  So does it mean the vector-like object from which this came is
> corrupted?
>
>> >When you say you don't see it: is it using 32bits or 64bits emacs ?
> 32-bit, the only one I have.
>
I'm not seeing the problem in a 32-bit build either, or in a 64-bit.  
And '0x4000000001013ffb' is not a 32-bit value, so I'm puzzled by the 
above GDB output.

Fabrice, what does the GDB command 'p sizeof p' say?  On my 32-bit 
build, it says 4.

The symptoms you report are consistent with being at commit 
b80c5ebc4f6afd54597012583c6a1390db0ade9c dated Mon Apr 13 23:26:13 2015 
-0700, which has an (in-hindsight) obvious bug that can trash 
save_window_state like that.  This bug should be fixed by the next 
commit 7744cc7e95bcae1df6911be5a9a941d73ea207f7 dated about an hour 
later.  Perhaps you got unlucky and did a 'git pull' during the bad 
hour?  But in that case I don't understand the "commit
b5919771aea2d43c64be381b7d7b395eeb1191bd" in your first email, as that's 
dated after both of the other two commits.

Maybe you are in an inconsistent build state?  That would explain both 
the wrong size and the commit hash discrepancy.  Can you reproduce the 
problem in a fresh checkout and build from scratch?

Re: Crash with tests

[Fabrice Popineau]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

>
>
>>  I'm not seeing the problem in a 32-bit build either, or in a 64-bit.
> And '0x4000000001013ffb' is not a 32-bit value, so I'm puzzled by the above
> GDB output.
>
> My build is a 64its build.


>
> Maybe you are in an inconsistent build state?  That would explain both the
> wrong size and the commit hash discrepancy.  Can you reproduce the problem
> in a fresh checkout and build from scratch?
>

Yuk. You seem to be right !
I would have expected a compilation failure, but at second thought, maybe
not.

Sorry for the noise. Thanks for the hint.

Fabrice

[-- Attachment #2: Type: text/html, Size: 1252 bytes --]