From: Dmitry Gutov <dgutov@yandex.ru>
To: joaotavora@gmail.com (João Távora)
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: electric-pair-mode as a minor mode?
Date: Mon, 13 Apr 2015 02:10:05 +0300 [thread overview]
Message-ID: <552AFB4D.4090407@yandex.ru> (raw)
In-Reply-To: <m2mw2d3sbq.fsf@gmail.com>
On 04/13/2015 01:16 AM, joaotavora@gmail.com (João Távora) wrote:
> (I pressed `M-p', not `M-n').
Right, that.
> That's right. Although I can't resist asking why these "Summary" and
> "Author" hints/cookies can't be some display-only element like a
> before-string in an overlay. Why are they implemented as actual buffer
> text?
I guess partly because it can be handled similarly to mail buffers (and
maybe, at some point, some code can be merged).
And while "Summary:" could be implemented as a before-string on an
overlay (or even purely with font-lock, maybe), other headers need extra
processing: transform the value, move it to a different part of the
buffer, etc. Aside from "Author" and "Signed-Off-By", we can encounter
"Fixes:" and now, after the ChangeLogs conversion,
"Copyright-paperwork-exempt:" and "Also-By:" (or some alternative thereof).
And good luck saving/restoring overlays in M-n/M-p implementations. Text
prop-based implementation would handle this better, but how to use them
in this context isn't necessarily apparent to me.
> Never tried it. Didn't know they existed even. I make commits from
> vc-dir and command line alternately as is more convenient, so I
> `log-edit-mode' in COMMIT_EDITMSG for a consistent UI.
I'm guessing git-commit-mode from MELPA would probably be a better fit,
even if it has different interface.
>> Maybe somewhere in `before-save-hook' of the new major mode?
>
> Won't kick in when the buffer doesn't need saving.
But COMMIT_EDITMSG needs to be saved, doesn't it?
> This seems works nicely though:
log-edit-callback looks like a nice option, too.
> Got it in my .emacs, but perhaps this could be installed, seems generic
> enough.
It should probably handle other headers as well. I don't know if Git
allows to set arguments like --author or --signed-off-by via some
special comments in the commit file, but if it did, that would allow to
unify the implementations nicely.
next prev parent reply other threads:[~2015-04-12 23:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 19:51 electric-pair-mode as a minor mode? Yuri D'Elia
2015-03-27 2:18 ` Stefan Monnier
2015-03-27 8:04 ` Yuri D'Elia
2015-03-27 13:19 ` Stefan Monnier
2015-03-27 11:18 ` João Távora
2015-03-27 13:25 ` Stefan Monnier
2015-03-27 14:09 ` João Távora
2015-03-27 18:20 ` Stefan Monnier
2015-03-28 16:11 ` João Távora
2015-03-28 20:36 ` Stefan Monnier
2015-03-28 21:47 ` João Távora
2015-03-28 23:09 ` João Távora
2015-03-29 4:01 ` Stefan Monnier
2015-03-29 20:41 ` João Távora
2015-03-30 0:54 ` Stefan Monnier
2015-03-30 10:46 ` João Távora
2015-03-30 13:53 ` Stefan Monnier
2015-03-30 15:43 ` João Távora
2015-03-30 20:33 ` Stefan Monnier
2015-03-30 20:42 ` João Távora
2015-03-30 21:47 ` João Távora
2015-03-30 22:02 ` Stefan Monnier
2015-04-11 16:06 ` João Távora
2015-04-12 11:56 ` Stefan Monnier
2015-04-12 13:16 ` João Távora
2015-04-12 16:39 ` Dmitry Gutov
2015-04-12 22:16 ` João Távora
2015-04-12 23:10 ` Dmitry Gutov [this message]
2015-04-15 21:32 ` João Távora
2015-04-15 13:59 ` Lars Magne Ingebrigtsen
2015-04-15 21:16 ` João Távora
2015-04-15 21:21 ` Lars Magne Ingebrigtsen
2015-04-15 21:39 ` João Távora
2015-04-15 21:43 ` Lars Magne Ingebrigtsen
2015-04-26 10:28 ` João Távora
2015-04-26 19:48 ` Lars Magne Ingebrigtsen
2015-04-27 2:29 ` Stefan Monnier
2015-03-27 19:38 ` Yuri D'Elia
2015-03-27 12:52 ` Tom Willemse
2015-03-27 19:01 ` Stefan Monnier
2015-03-28 15:47 ` João Távora
2015-03-28 17:37 ` bug#19528: " Glenn Morris
2015-03-28 21:01 ` João Távora
2015-04-14 6:28 ` Glenn Morris
2015-03-28 15:47 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552AFB4D.4090407@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.