From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Johan Bockgård" <bojohan@gnu.org>, emacs-devel@gnu.org
Subject: Re: commit-msg hook
Date: Fri, 10 Apr 2015 19:42:53 -0700 [thread overview]
Message-ID: <55288A2D.5030809@cs.ucla.edu> (raw)
In-Reply-To: <83y4m0tgac.fsf@gnu.org>
Eli Zaretskii wrote:
> On MS-Windows, this hook fails commits with valid UTF-8 characters in
> the log messages, probably because the version of Gawk I have here is
> too old (3.0.4; that's what MSYS comes with).
Ouch. That's old. Why is MSYS still using a circa-1999 gawk? Can we talk the
MSYS folks into having something more up-to-date?
> The mawk 1.3.3 replacement regexp for non_print does work, so I
> suggest to have a Gawk version check in the script
It's better to check for features rather than versions. I got a copy of Gawk
3.0.4 out of mothballs and hacked for a while until I got something that worked
for me.
> Btw, when the hook is run by Git, the "; see 'CONTRIBUTE'" part of the
> message is not shown; could it be that the semi-colon gets interpreted
> by the shell, or something like that? (My Git version is 1.9.5.)
Most likely you've got an obsolete hook. Please try "git pull" followed by
"./autogen.sh".
> I would also suggest to say explicitly in the message that the commit
> was aborted, because it is not at all clear
Thanks, good suggestion.
Johan Bockgård wrote:
> Also, the hook should ignore the stuff after
>
> # ------------------------ >8 ------------------------
> # Do not touch the line above.
> # Everything below will be removed.
>
> when running the checks on the commit message. (Inserted by commit -v.)
Thanks, I had forgotten about commit -v.
I installed some patches to try to fix the above problems (assuming my guess is
right about the obsolete hook). You can do an "./autogen.sh" after pulling
these patches.
next prev parent reply other threads:[~2015-04-11 2:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 10:43 commit-msg hook Eli Zaretskii
2015-04-10 18:23 ` Johan Bockgård
2015-04-11 2:42 ` Paul Eggert [this message]
2015-04-11 7:24 ` Eli Zaretskii
2015-04-11 9:55 ` Eli Zaretskii
2015-04-11 9:59 ` Eli Zaretskii
2015-04-11 12:42 ` Dmitry Gutov
2015-04-11 14:29 ` Eli Zaretskii
2015-04-11 15:13 ` Dmitry Gutov
2015-04-11 15:17 ` Eli Zaretskii
2015-04-12 3:36 ` Stefan Monnier
2015-04-12 18:54 ` chad
2015-04-11 15:40 ` Paul Eggert
2015-04-11 16:40 ` Eli Zaretskii
2015-04-11 20:09 ` Paul Eggert
2015-04-12 16:10 ` Eli Zaretskii
2015-04-13 15:48 ` Eli Zaretskii
2015-04-13 18:37 ` Paul Eggert
2015-04-13 20:18 ` Eli Zaretskii
2015-04-13 21:19 ` Paul Eggert
2015-04-14 15:08 ` Eli Zaretskii
2015-04-14 17:01 ` Paul Eggert
2015-04-14 17:09 ` Eli Zaretskii
2015-04-14 17:42 ` Paul Eggert
2015-04-14 18:01 ` Eli Zaretskii
2015-04-14 18:32 ` Paul Eggert
2015-04-14 18:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55288A2D.5030809@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bojohan@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.