From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20290: 25.0.50; Use unified diff format by default, and recommend using it in reports and patches Date: Fri, 10 Apr 2015 15:26:38 +0300 Message-ID: <5527C17E.1040404@yandex.ru> References: <86bnix6p9l.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1428668905 21886 80.91.229.3 (10 Apr 2015 12:28:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Apr 2015 12:28:25 +0000 (UTC) Cc: 20290@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 10 14:28:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YgY2c-0001m9-QQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Apr 2015 14:28:10 +0200 Original-Received: from localhost ([::1]:39065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgY2c-0008Iv-3V for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Apr 2015 08:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgY2Y-0008In-Bg for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2015 08:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgY2V-0007Mz-4S for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2015 08:28:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgY2V-0007Mt-1J for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2015 08:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YgY2U-0005Sw-IQ for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2015 08:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Apr 2015 12:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20290-submit@debbugs.gnu.org id=B20290.142866883320950 (code B ref 20290); Fri, 10 Apr 2015 12:28:02 +0000 Original-Received: (at 20290) by debbugs.gnu.org; 10 Apr 2015 12:27:13 +0000 Original-Received: from localhost ([127.0.0.1]:51920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgY1g-0005Rq-Vw for submit@debbugs.gnu.org; Fri, 10 Apr 2015 08:27:13 -0400 Original-Received: from mail-wg0-f43.google.com ([74.125.82.43]:36612) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YgY1f-0005RV-8K for 20290@debbugs.gnu.org; Fri, 10 Apr 2015 08:27:11 -0400 Original-Received: by wgsk9 with SMTP id k9so15872252wgs.3 for <20290@debbugs.gnu.org>; Fri, 10 Apr 2015 05:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EnP/piZxggip4q3b09o8ZuMWnlRAcenhy/srbFmt89I=; b=hG8+79rteHQrXrxj4kSPh86nUhcgKzy8rqFHwLhWchaP4bUXxmDzx12Mvk1wAJBRp8 lPm9WSfFA5IRZOuFQPi/BulnmjJJiOiy5bSw+hmdpgdhWxZ1LIOZ89mgHOLvsMH4/q2q oRyrvUv4Wok9Odq9voBxf8cuR6kVcefyPAqWE3z5s+6hT/VLe8cfqd72uV+lwNiCPsyS R4NCyWi7nPMFIS3wBOfWyTXRjnPyxZ9o/KY/rOCAEcFEV1nOCH7Iv2fZBiNCOXZQKOGm bZeGbway2uIcvGt6oo8gXdVDuCL9dj88QUQvqwLl1wn5PpBkFs1GHvNIXXm8fr9JWrV8 FA8Q== X-Received: by 10.194.48.12 with SMTP id h12mr2762853wjn.74.1428668805650; Fri, 10 Apr 2015 05:26:45 -0700 (PDT) Original-Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id cf12sm2755386wjb.10.2015.04.10.05.26.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 05:26:44 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101377 Archived-At: On 04/10/2015 10:33 AM, Glenn Morris wrote: > What's the reason for changing the long-standing default? Unified diffs are considerably more popular. IIRC Stefan prefers them, and the vast majority of patches we've received lately (even though Emacs's documentation asks for the context format), were unified. Which signals that users prefer, or at least are more used to, unified diffs. I've recently wanted to show off the "refinement" diff-mode feature to a colleague, and that stumbled on Emacs producing a context diff by default, so I had to go back to my machine, and look up which option to change (yes, I know there's a conversion command; haven't thought about that at the time). > * Use `diff -c' to make your diffs. Diffs without context are hard > to install reliably. More than that, they are hard to study; we > must always study a patch to decide whether we want to install it. This is about the "normal" diff format, which, uh, nobody ever uses now? > Unidiff format is better than contextless diffs, but not as easy > to read as `-c' format. And here I disagree: unified diffs are easier, because they clearly show you the changes. You don't need to compare the "before" and "after" in your head, to figure out what exactly changed. Maybe it can be a bit harder to read, but it's much easier to review. Note that we already indirectly ask the users to send their patches in the unified format in CONTRIBUTE, because that's what 'git format-patch' will create. > Also, one day is not long enough to allow people time to respond, > for any Emacs issue. Okay, let's wait until the next week.