From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 4e23cd0 4/5: * mail/rmail.el (rmail-show-message-1): When displaying a mime message, Date: Mon, 06 Apr 2015 01:32:49 +0300 Message-ID: <5521B811.8070603@yandex.ru> References: <20150405124321.362.95112@vcs.savannah.gnu.org> <552130FE.1010101@yandex.ru> <83mw2mn2no.fsf@gnu.org> <5521359D.2000509@yandex.ru> <83fv8emvgq.fsf@gnu.org> <55219139.8040507@yandex.ru> <83oan2l4pk.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1428273203 26191 80.91.229.3 (5 Apr 2015 22:33:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Apr 2015 22:33:23 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 06 00:33:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yet6O-0008LR-LB for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2015 00:33:12 +0200 Original-Received: from localhost ([::1]:37758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yet6N-0004IB-Vr for ged-emacs-devel@m.gmane.org; Sun, 05 Apr 2015 18:33:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yet6A-0004El-KQ for emacs-devel@gnu.org; Sun, 05 Apr 2015 18:32:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yet65-00039D-BH for emacs-devel@gnu.org; Sun, 05 Apr 2015 18:32:58 -0400 Original-Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:32798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yet65-00038m-3a; Sun, 05 Apr 2015 18:32:53 -0400 Original-Received: by wgin8 with SMTP id n8so14593448wgi.0; Sun, 05 Apr 2015 15:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sBN6KwY7gcyQY3hxkz7BBL2w8XB8ameNjgNgKm0z41A=; b=ByFr98cFSaspzkaqm4LmEBE+YoqFDWNwUED0e7aTXsuVpGg2AzyFKun2zvRjgJ2V1x EcLT/DHg88OLkH1qVtM5b152vjcoFJSz9b0fbgKwupzoS2wXAOhMctAvsZ3sujI7SlNI WOlaN0GvfO5Yas8TZ6aIPG95Uqsol0+iezcUbGaHTiADyTB7EP9qRoUxf4zbkX76E/ed pAbgUVlSaVEzEqAYJLvIm9MpIF4nOlmjAUzGjjq+pV3G0d5IWh2b6FZKqyV8WOY/FwrG Jbg69CaIFLwt4gpQiJDDRsCedmilA/eD6mbzMmyf9hZA67MfGYvlrwFMu5YrlLsZegvS m4TQ== X-Received: by 10.180.88.131 with SMTP id bg3mr23376875wib.71.1428273172425; Sun, 05 Apr 2015 15:32:52 -0700 (PDT) Original-Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id wr2sm3962035wjb.45.2015.04.05.15.32.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Apr 2015 15:32:51 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: <83oan2l4pk.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184986 Archived-At: On 04/05/2015 11:07 PM, Eli Zaretskii wrote: > Wrong impression. Okay then. > That item is a dead end in practice, and is too harsh even if it were > practical. I think it was one of the discussed options. And why a dead end? I'm sure we can handle applying 4-5 patches a year from RMS manually. > You are missing the point: I meant "C-x v v", not some other command > available with VC. It's "C-x v v" that got Richard in trouble in the > first place, by trying to commit a single file in the middle of a > failed merge. And I meant that an automated solution would be great to have, but it's the responsibility of every committer to pay attention and not mess up. I think that should be pretty obvious. >> Editing the already-created commits is more complicated, but I think >> there was some advice on that subject too, in the humongous thread. > > It's also on the Wiki. "If you made a mistake"? That only helps when we need to change the most recent commit. Which is good, but probably not enough. > Which is why it is important to help those users find the right > procedures they can safely follow. Having better instructions will, of course, be a beneficial side of this whole enterprise. > I don't mind switching the order. I myself use "git show". It's just > that most others suggested "git diff", and its syntax is a bit simpler > when more than one commit is involved. I think the committer had probably already tested the installed changes for functionality. So the thing that's most often in need of checking is writing: comments, docs and commit messages. > I don't think there's lack of motivation in this case. In my book, "I want everything to work like CVS" means a lack of motivation to learn. >> But not everyone has to be an Emacs committer. That's not harsh: people >> can have better priorities in life. > > Applied to veteran Emacs developers, it _is_ harsh, at least IMO. Maybe to any other veteran, but since Richard holds the "master key" anyway, that wouldn't be like locking him out of the project. Considering the mega-thread is clocking at 505 messages now, would it really not have been a better solution? >> Cue the "teach a man how to fish" proverb. It seems to me that the >> result is only one fish on Richard's table, and one that was pretty >> haphazardly prepared. > > We all need help from time to time. I see no reason to tell people > they goofed too many times, especially if they already know that. "Haphazardly prepared" by other people, of course, because there's really no possible way to reliably get instructions from this large a crowd, all shouting at the same time.