From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 4e23cd0 4/5: * mail/rmail.el (rmail-show-message-1): When displaying a mime message,
Date: Sun, 05 Apr 2015 22:47:05 +0300 [thread overview]
Message-ID: <55219139.8040507@yandex.ru> (raw)
In-Reply-To: <83fv8emvgq.fsf@gnu.org>
On 04/05/2015 06:43 PM, Eli Zaretskii wrote:
>> 1) Forget the "push automatically after commit" nonsense
>
> The discussion is waaaay beyond that, so this is no longer relevant.
That's not my impression from the last sentence in
http://lists.gnu.org/archive/html/emacs-devel/2015-04/msg00156.html
> not very relevant
> to the issue at hand, which had to do with user confusion more than
> with anything else.
Hence the item 2 below.
> And if we think double-checking each commit before pushing is a must,
> we should make VC support that seamlessly. After all, all Richard
> used was VC.
We can come up with a more automatic solution, but even now it's
entirely doable using VC: `C-x v L' to open the log buffer, and when in
it, `C-m' to read the commit message, `d' to see the corresponding diff.
Editing the already-created commits is more complicated, but I think
there was some advice on that subject too, in the humongous thread.
>> 2) People who don't know how to do that, and are unwilling to learn, or
>> who aren't confident in their results anyway should post patches to the
>> mailing list.
>
> I disagree. We should let people who want to use a CVS-like workflow
> do that. It's possible if done correctly.
I'm not saying it's not possible, but a wrong commit message is extra
work for someone else who will have to correct it. It'll become more so
when the change log files are auto-generated.
> The previous instructions
> for that were sub-optimal, but I think they are now much more clear,
> accurate, and concise to allow using that workflow safely.
It's better, but I think recommending `git diff origin/master' as the
first option is suboptimal, because it ignores the commit messages,
which we do want to look right.
> I see no reasons for being this harsh just because some contributors
> don't yet master Git enough to use it like we think they should.
The workflow details aside, I think a committer should be motivated
enough to examine the result of their work before pushing. And if they
don't know how, learn that on their own.
But not everyone has to be an Emacs committer. That's not harsh: people
can have better priorities in life.
>> Had Richard started with that, a lot of time would've been saved, on
>> many ends.
>
> Time spent helping someone is time well spent, at least as long as
> it's my time.
Cue the "teach a man how to fish" proverb. It seems to me that the
result is only one fish on Richard's table, and one that was pretty
haphazardly prepared.
next prev parent reply other threads:[~2015-04-05 19:47 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150405124321.362.95112@vcs.savannah.gnu.org>
[not found] ` <E1Yejtc-00007F-4B@vcs.savannah.gnu.org>
2015-04-05 12:56 ` [Emacs-diffs] master 4e23cd0 4/5: * mail/rmail.el (rmail-show-message-1): When displaying a mime message, Dmitry Gutov
2015-04-05 13:08 ` Eli Zaretskii
2015-04-05 13:16 ` Dmitry Gutov
2015-04-05 15:43 ` Eli Zaretskii
2015-04-05 19:47 ` Dmitry Gutov [this message]
2015-04-05 20:07 ` Eli Zaretskii
2015-04-05 22:32 ` Dmitry Gutov
2015-04-06 7:54 ` Eli Zaretskii
2015-04-06 12:03 ` Dmitry Gutov
2015-04-06 12:24 ` Eli Zaretskii
2015-04-06 23:32 ` Dmitry Gutov
2015-04-07 6:12 ` Eli Zaretskii
2015-04-07 16:13 ` Richard Stallman
2015-04-07 16:32 ` Eli Zaretskii
2015-04-07 16:51 ` Alan Mackenzie
2015-04-07 17:12 ` Eli Zaretskii
2015-04-07 20:11 ` Alan Mackenzie
2015-04-08 6:36 ` Eli Zaretskii
2015-04-08 1:38 ` Dmitry Gutov
2015-04-08 10:48 ` Alan Mackenzie
2015-04-08 22:19 ` chad
2015-04-09 13:16 ` Richard Stallman
2015-04-09 1:16 ` Dmitry Gutov
2015-04-09 7:27 ` Eli Zaretskii
2015-04-09 12:20 ` Dmitry Gutov
2015-04-09 12:51 ` Eli Zaretskii
2015-04-09 16:12 ` Dmitry Gutov
2015-04-08 18:19 ` Richard Stallman
2015-04-09 1:31 ` Dmitry Gutov
2015-04-09 7:36 ` Eli Zaretskii
2015-04-09 16:24 ` Stephen J. Turnbull
2015-04-09 16:35 ` Eli Zaretskii
2015-04-10 4:53 ` Stephen J. Turnbull
2015-04-10 7:49 ` Eli Zaretskii
2015-04-10 8:30 ` Stephen J. Turnbull
2015-04-11 19:18 ` Richard Stallman
2015-04-12 6:10 ` Stephen J. Turnbull
2015-04-13 21:06 ` Alan Mackenzie
2015-04-13 23:08 ` Stephen J. Turnbull
2015-04-14 17:16 ` Alan Mackenzie
2015-04-14 17:31 ` Eli Zaretskii
2015-04-14 21:23 ` João Távora
2015-04-15 2:46 ` Eli Zaretskii
2015-04-15 8:09 ` Harald Hanche-Olsen
2015-04-15 16:13 ` Eli Zaretskii
2015-04-15 16:21 ` Harald Hanche-Olsen
2015-04-15 16:36 ` Eli Zaretskii
2015-04-14 21:47 ` Steinar Bang
2015-04-08 18:21 ` Richard Stallman
2015-04-08 18:29 ` Eli Zaretskii
2015-04-08 19:18 ` John Yates
2015-04-09 13:41 ` Stephen J. Turnbull
2015-04-08 1:32 ` Dmitry Gutov
2015-04-08 18:19 ` Richard Stallman
2015-04-09 1:19 ` Dmitry Gutov
2015-04-09 7:31 ` Eli Zaretskii
2015-04-09 11:43 ` Dmitry Gutov
2015-04-07 20:45 ` Stephen J. Turnbull
2015-04-08 5:39 ` Eli Zaretskii
2015-04-05 17:42 ` Richard Stallman
2015-04-05 18:04 ` Eli Zaretskii
2015-04-06 5:50 ` Richard Stallman
2015-04-06 7:43 ` Eli Zaretskii
2015-04-06 7:45 ` Harald Hanche-Olsen
2015-04-07 16:13 ` Richard Stallman
2015-04-07 17:05 ` Eli Zaretskii
2015-04-08 12:02 ` Sebastien Vauban
2015-04-08 12:26 ` Harald Hanche-Olsen
2015-04-08 18:01 ` Stephen J. Turnbull
2015-04-08 12:38 ` Eli Zaretskii
2015-04-15 0:34 ` Rostislav Svoboda
2015-04-05 17:42 ` Richard Stallman
2015-04-05 19:01 ` Harald Hanche-Olsen
2015-04-05 21:00 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55219139.8040507@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.