Re: RFC: DWIM for killing *shell* and a more process-query-on-exit

[Daniel Colascione <dancol@dancol.org>]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On 03/29/2015 12:23 AM, Andreas Schwab wrote:
>> @@ -1156,28 +1157,31 @@ This function returns FLAG.  */)
>>    return flag;
>>  }
>>
>> -DEFUN ("set-process-query-on-exit-flag",
>> -       Fset_process_query_on_exit_flag, Sset_process_query_on_exit_flag,
>> +DEFUN ("set-process-query-on-exit",
>> +       Fset_process_query_on_exit, Sset_process_query_on_exit,
> 
> This should be called set-process-query-on-exit-function.

It's not always a function.

>> @@ -1449,7 +1453,7 @@ usage: (make-process &rest ARGS)  */)
>>    pset_command (XPROCESS (proc), Fcopy_sequence (command));
>>
>>    if (tem = Fplist_get (contact, QCnoquery), !NILP (tem))
>> -    XPROCESS (proc)->kill_without_query = 1;
>> +    XPROCESS (proc)->query_on_exit = tem;
> 
> This inverts the meaning of :noquery.

Yes, that's a silly bug.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]