From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#20212: 24.4: bookmark.el: function hangs on EOF (FIX INCLUDED) (bookmark-bmenu-goto-bookmark) Date: Fri, 27 Mar 2015 05:42:52 -0400 Message-ID: <5515261C.1000904@gmx.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El" X-Trace: ger.gmane.org 1427449485 24953 80.91.229.3 (27 Mar 2015 09:44:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Mar 2015 09:44:45 +0000 (UTC) To: 20212@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 27 10:44:32 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YbQoE-0001Ii-6T for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Mar 2015 10:44:10 +0100 Original-Received: from localhost ([::1]:49134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQoD-0001KJ-DY for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Mar 2015 05:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQo9-0001K7-I8 for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQo6-0005lU-RY for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:44:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQo6-0005lQ-O9 for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YbQo6-00077P-Ei for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Mar 2015 09:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142744943227332 (code B ref -1); Fri, 27 Mar 2015 09:44:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Mar 2015 09:43:52 +0000 Original-Received: from localhost ([127.0.0.1]:37818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbQnv-00076l-M1 for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53885) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YbQnt-00076Y-Kn for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQnn-0005jE-BR for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:44 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnn-0005jA-6W for submit@debbugs.gnu.org; Fri, 27 Mar 2015 05:43:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnm-0001Jc-3L for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbQnj-0005iV-C3 for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:42 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:62962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbQnj-0005iE-1p for bug-gnu-emacs@gnu.org; Fri, 27 Mar 2015 05:43:39 -0400 Original-Received: from [192.168.1.3] ([96.232.130.59]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LgIWi-1ZE2t229uG-00niNh for ; Fri, 27 Mar 2015 10:43:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 OpenPGP: url=hkp://keys.gnupg.net X-Provags-ID: V03:K0:9YZXS+YkwzIlKcvAqW1nxNSo0RZK0XBBIyDjyqI6zprEqJQIC/6 0JoS+oJlDfeu4Na2UdQ4OeVEPfQSrDijpdZkYJjiVo6j2Po0p+O/goTpqYzjEr1EKcePS3E pXFAayMj/TbbASfy3jvVeZnvCUCjwxPRZsUWoHCWnAtFtX9uJo7xfRtcjprx0gU9ROrwUd7 +Rx6pAUzTRFdM0Rz1DPbA== X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100971 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El Content-Type: multipart/mixed; boundary="------------030002080105050300010700" This is a multi-part message in MIME format. --------------030002080105050300010700 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable While looking to address Stefan Monnier's comments to bug #20150, I encountered this bug in function bookmark-bmenu-goto-bookmark. If the function does not find the requested bookmark before EOF, it continues endlessly. patch attached. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --------------030002080105050300010700 Content-Type: text/x-patch; name="2015-03-27_001.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="2015-03-27_001.patch" --- bookmark.el 2015-03-23 04:52:30.503739608 -0400 +++ bookmark-new.el 2015-03-27 05:32:00.390173984 -0400 @@ -2064,7 +2064,8 @@ (defun bookmark-bmenu-goto-bookmark (name) "Move point to bookmark with name NAME." (goto-char (point-min)) - (while (not (equal name (bookmark-bmenu-bookmark))) + (while (and (not (equal name (bookmark-bmenu-bookmark))) + (not (equal (point) (point-max)))) (forward-line 1)) (forward-line 0)) =20 --------------030002080105050300010700-- --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVFSYcAAoJEDvrUfDmCx9L3x4P/3ZTKpSrSUmm/p041fiQZwqZ 9/BjOfRXUwaazNSpO6+lHfl7Dh5bHpIczMSaKvRO3zjvnY2RxvuDw9vKNwUl6E4+ lndafaoHrEr7JdFizHoc+rdfkm5CheA1dztcq4u5iTLJrO5oRqfAB/QwWEkLriQW SGxXeZ0sq0AVXx/cDyuzGs8D8GtM5b+6IKyE2c/dogvk+fZxS9Gb1dziYcCA/dlb m9Imb6823BFXKpFRnJLsdUbErN4hQP/tLi2XvYzirLIAv47sbWv1N3V41q6hvSwZ OTOBJP+FzaY+pTaLkM7yX0c5zrSoS/huZRBju/klf+xl6MmQt+J3ummgAFJ+WlO8 qBTvNNaJqO0AgXLOoffQvtnqijVZsMYjRClThaJr6vClQUIvvzNLEiCjsV03qya+ Z+ZwjuKURNbwlqAB6rHqTm/XapSj4qsc+wcj9TYHS/8jMyYXCZrmW2YWsIVNr3vd eG9s4h4Gkod5n3apnZS/RFAA+EnfUJWyuApcp5t3vMb+7g9OI77L2/LjlwENDCrt RsCPkJ+JN6fbLjmzVRSNz/fsD6T51JaXQprDnhjQTouB+hnrv9HwAkZCZk7J/L5d WnuInCyITdHPXmNAK0SBtEUDmTrKRQ7GDstiIeGbRD26BEblkPAnRkDU8Jr7VArf wDWbuPwN0YI07ZfZwVgV =T41G -----END PGP SIGNATURE----- --Pf3svLgK1ex5dmLDBsad7QM4EQHkMp1El--